feat: [UIE-8806, UIE-8881, UIE-8882, UIE-8931 ] - IAM RBAC: fix bugs (linode#12371)

* feat: [UIE-8806, UIE-8881, UIE-8882, UIE-8931 ] - IAM RBAC: fix bugs

* changeset

Author: aaleksee-akamai

packages/manager/.changeset/pr-12371-upcoming-features-1749732346697.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+IAM RBAC: Standardize drawer error messages, add an error message for the lasc account admin ([#12371](https://github.com/linode/manager/pull/12371))

packages/manager/src/features/IAM/Roles/RolesTable/AssignSelectedRolesDrawer.tsx

@@ -22,10 +22,7 @@ import { LinkButton } from 'src/components/LinkButton';
 import { StyledLinkButtonBox } from 'src/components/SelectFirewallPanel/SelectFirewallPanel';
 import { AssignSingleSelectedRole } from 'src/features/IAM/Roles/RolesTable/AssignSingleSelectedRole';
 
-import {
-  INTERNAL_ERROR_UPDATE_PERMISSION,
-  NO_CHANGES_SAVED,
-} from '../../Shared/constants';
+import { INTERNAL_ERROR_NO_CHANGES_SAVED } from '../../Shared/constants';
 import { mergeAssignedRolesIntoExistingRoles } from '../../Shared/utilities';
 
 import type { AssignNewRoleFormValues } from '../../Shared/utilities';
@@ -109,7 +106,9 @@ export const AssignSelectedRolesDrawer = ({
 
       handleClose();
     } catch (error) {
-      setError(error.field ?? 'root', { message: error[0].reason });
+      setError(error.field ?? 'root', {
+        message: INTERNAL_ERROR_NO_CHANGES_SAVED,
+      });
     }
   };
 
@@ -127,13 +126,7 @@ export const AssignSelectedRolesDrawer = ({
       <FormProvider {...form}>
         <form onSubmit={handleSubmit(onSubmit)}>
           {formState.errors.root?.message && (
-            <Notice variant="error">
-              <Typography>
-                {INTERNAL_ERROR_UPDATE_PERMISSION}
-                <br />
-                {NO_CHANGES_SAVED}
-              </Typography>
-            </Notice>
+            <Notice text={formState.errors.root?.message} variant="error" />
           )}
           <Typography sx={{ marginBottom: 2.5 }}>
             Select the user you want to assign selected roles to. Some roles

packages/manager/src/features/IAM/Shared/AssignedRolesTable/ChangeRoleDrawer.tsx

@@ -18,7 +18,12 @@ import { Controller, useForm } from 'react-hook-form';
 import { Link } from 'src/components/Link';
 
 import { AssignedPermissionsPanel } from '../AssignedPermissionsPanel/AssignedPermissionsPanel';
-import { changeUserRole, getAllRoles, getRoleByName } from '../utilities';
+import {
+  changeUserRole,
+  getAllRoles,
+  getErrorMessage,
+  getRoleByName,
+} from '../utilities';
 
 import type { DrawerModes, EntitiesOption, ExtendedRoleView } from '../types';
 import type { RolesType } from '../utilities';
@@ -110,9 +115,9 @@ export const ChangeRoleDrawer = ({ mode, onClose, open, role }: Props) => {
 
       handleClose();
     } catch (errors) {
-      for (const error of errors) {
-        setError(error?.field ?? 'root', { message: error.reason });
-      }
+      setError('root', {
+        message: getErrorMessage(errors),
+      });
     }
   };
 

packages/manager/src/features/IAM/Shared/AssignedRolesTable/UnassignRoleConfirmationDialog.tsx

@@ -6,7 +6,7 @@ import React from 'react';
 
 import { ConfirmationDialog } from 'src/components/ConfirmationDialog/ConfirmationDialog';
 
-import { deleteUserRole } from '../utilities';
+import { deleteUserRole, getErrorMessage } from '../utilities';
 
 import type { ExtendedRoleView } from '../types';
 
@@ -74,7 +74,7 @@ export const UnassignRoleConfirmationDialog = (props: Props) => {
           style={{ padding: 0 }}
         />
       }
-      error={error?.[0].reason}
+      error={getErrorMessage(error)}
       onClose={onClose}
       open={open}
       title={`Unassign the ${role?.name} role?`}

packages/manager/src/features/IAM/Shared/AssignedRolesTable/UpdateEntitiesDrawer.tsx

@@ -6,6 +6,7 @@ import React from 'react';
 import { Controller, FormProvider, useForm } from 'react-hook-form';
 
 import { AssignedPermissionsPanel } from '../AssignedPermissionsPanel/AssignedPermissionsPanel';
+import { INTERNAL_ERROR_NO_CHANGES_SAVED } from '../constants';
 import { toEntityAccess } from '../utilities';
 
 import type { EntitiesOption, ExtendedRoleView } from '../types';
@@ -92,7 +93,9 @@ export const UpdateEntitiesDrawer = ({ onClose, open, role }: Props) => {
       handleClose();
     } catch (errors) {
       for (const error of errors) {
-        setError(error?.field ?? 'root', { message: error.reason });
+        setError(error?.field ?? 'root', {
+          message: INTERNAL_ERROR_NO_CHANGES_SAVED,
+        });
       }
     }
   };

packages/manager/src/features/IAM/Shared/Entities/utils.test.ts

@@ -15,9 +15,7 @@ describe('getCreateLinkForEntityType', () => {
     expect(getCreateLinkForEntityType('placement_group')).toBe(
       '/placement-groups/create'
     );
-    expect(getCreateLinkForEntityType('lkecluster')).toBe(
-      '/kubernetes/clusters'
-    );
+    expect(getCreateLinkForEntityType('lkecluster')).toBe('/kubernetes/create');
   });
 });
 

packages/manager/src/features/IAM/Shared/Entities/utils.ts

@@ -33,7 +33,7 @@ export const getCreateLinkForEntityType = (
   }
 
   if (entityType === 'lkecluster') {
-    return '/kubernetes/clusters';
+    return '/kubernetes/create';
   }
 
   return `/${entityType}s/create`;

packages/manager/src/features/IAM/Shared/constants.ts

@@ -7,9 +7,9 @@ export const NO_ASSIGNED_ROLES_TEXT = `The user doesn't have any roles assigned
 
 export const NO_ASSIGNED_ENTITIES_TEXT = `The user doesn't have any entity access roles assigned yet. Once you assign the user a role on specific entities, these entities will show up here.`;
 
-export const INTERNAL_ERROR_UPDATE_PERMISSION = `Internal Error - Issue with updating permissions.`;
+export const INTERNAL_ERROR_NO_CHANGES_SAVED = `Internal Error. No changes were saved.`;
 
-export const NO_CHANGES_SAVED = `No changes were saved.`;
+export const LAST_ACCOUNT_ADMIN_ERROR = `Failed to unassigned the role. You need to have at least one user with the account_admin role on your acount.`;
 
 export const ERROR_STATE_TEXT =
   'An unexpected error occurred. Refresh the page or try again later.';

packages/manager/src/features/IAM/Shared/utilities.test.ts

@@ -1,12 +1,17 @@
 import { accountRolesFactory } from 'src/factories/accountRoles';
 import { userRolesFactory } from 'src/factories/userRoles';
 
+import {
+  INTERNAL_ERROR_NO_CHANGES_SAVED,
+  LAST_ACCOUNT_ADMIN_ERROR,
+} from './constants';
 import {
   changeRoleForEntity,
   changeUserRole,
   deleteUserEntity,
   deleteUserRole,
   getAllRoles,
+  getErrorMessage,
   getFacadeRoleDescription,
   getFormattedEntityType,
   getRoleByName,
@@ -817,3 +822,37 @@ describe('mapEntityTypesForSelect', () => {
     ]);
   });
 });
+
+describe('getErrorMessage', () => {
+  it('should return LAST_ACCOUNT_ADMIN_ERROR if the error contains "Removing last account admin"', () => {
+    const errors = [
+      {
+        reason: 'Request made to janus is invalid',
+        field: 'Bad janus request',
+      },
+      {
+        reason:
+          'Can not remove account admin access from the last account admin on the account',
+        field: 'Removing last account admin',
+      },
+    ];
+    const result = getErrorMessage(errors);
+    expect(result).toBe(LAST_ACCOUNT_ADMIN_ERROR);
+  });
+
+  it('should return INTERNAL_ERROR_NO_CHANGES_SAVED if the error does not contain "Removing last account admin"', () => {
+    const errors = [
+      {
+        field: 'An unexpected error occurred.',
+        reason: 'An unexpected error occurred.',
+      },
+    ];
+    const result = getErrorMessage(errors);
+    expect(result).toBe(INTERNAL_ERROR_NO_CHANGES_SAVED);
+  });
+
+  it('should return undefined if there are no errors', () => {
+    const result = getErrorMessage(null);
+    expect(result).toBeUndefined();
+  });
+});

packages/manager/src/features/IAM/Shared/utilities.ts

@@ -1,6 +1,10 @@
 import { capitalize, capitalizeAllWords } from '@linode/utilities';
 
-import { PAID_ENTITY_TYPES } from './constants';
+import {
+  INTERNAL_ERROR_NO_CHANGES_SAVED,
+  LAST_ACCOUNT_ADMIN_ERROR,
+  PAID_ENTITY_TYPES,
+} from './constants';
 
 import type {
   EntitiesOption,
@@ -12,6 +16,7 @@ import type {
 import type {
   AccountAccessRole,
   AccountEntity,
+  APIError,
   EntityAccess,
   EntityAccessRole,
   EntityType,
@@ -515,3 +520,15 @@ export const mergeAssignedRolesIntoExistingRoles = (
   });
   return selectedPlusExistingRoles;
 };
+
+export const getErrorMessage = (error: APIError[] | null) => {
+  const isLastAccountAdmin = error?.some(
+    (err) => err.field === 'Removing last account admin'
+  );
+
+  const errorMessage = isLastAccountAdmin
+    ? LAST_ACCOUNT_ADMIN_ERROR
+    : INTERNAL_ERROR_NO_CHANGES_SAVED;
+
+  return error ? errorMessage : undefined;
+};