fix: [M3-10482] - Add missing firewall_apply event messages (linode#12685)

* firewall event message fixes

* Added changeset: Missing `firewall_apply` event messages

* other firewall messages

* add todo comment

* spacing

* Added changeset: Temporarily fix Linode Interface `firewall_device_add` event message

* update messages based on feedback

* address feedback @cpathipa

* update type

Author: coliu-akamai

packages/manager/.changeset/pr-12685-fixed-1755272623309.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Missing `firewall_apply` event messages ([#12685](https://github.com/linode/manager/pull/12685))

packages/manager/.changeset/pr-12685-upcoming-features-1755276113969.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Temporarily fix Linode Interface `firewall_device_add` event message ([#12685](https://github.com/linode/manager/pull/12685))

packages/manager/src/features/Events/factories/firewall.tsx

@@ -1,20 +1,55 @@
+import { capitalize } from '@linode/utilities';
 import * as React from 'react';
 
 import { formattedTypes } from 'src/features/Firewalls/FirewallDetail/Devices/constants';
 
 import { EventLink } from '../EventLink';
 
 import type { PartialEventMap } from '../types';
+import type { Event } from '@linode/api-v4';
 import type { FirewallDeviceEntityType } from '@linode/api-v4';
 
+const entityPrefix = (e: Event) => {
+  const type = e?.entity?.type ? capitalize(e.entity.type) : null;
+
+  return type ? (
+    <>
+      {type} <EventLink event={e} to="entity" />{' '}
+    </>
+  ) : null;
+};
+
 export const firewall: PartialEventMap<'firewall'> = {
   firewall_apply: {
-    notification: (e) => (
-      <>
-        Firewall <EventLink event={e} to="entity" /> has been{' '}
-        <strong>applied</strong>.
-      </>
-    ),
+    failed: (e) => {
+      return (
+        <>
+          {entityPrefix(e)} Firewall update could <strong>not</strong> be{' '}
+          <strong>applied</strong>.
+        </>
+      );
+    },
+    finished: (e) => {
+      return (
+        <>
+          {entityPrefix(e)} Firewall update has been <strong>applied</strong>.
+        </>
+      );
+    },
+    scheduled: (e) => {
+      return (
+        <>
+          {entityPrefix(e)} Firewall update is <strong>scheduled</strong>.
+        </>
+      );
+    },
+    started: (e) => {
+      return (
+        <>
+          {entityPrefix(e)} Firewall update has <strong>started</strong>.
+        </>
+      );
+    },
   },
   firewall_create: {
     notification: (e) => (
@@ -34,8 +69,10 @@ export const firewall: PartialEventMap<'firewall'> = {
   firewall_device_add: {
     notification: (e) => {
       if (e.secondary_entity?.type) {
+        // TODO - Linode Interfaces [M3-10447] - clean this up when API ticket [VPC-3359] is completed
         const secondaryEntityName =
-          formattedTypes[e.secondary_entity.type as FirewallDeviceEntityType];
+          formattedTypes[e.secondary_entity.type as FirewallDeviceEntityType] ??
+          'Linode Interface';
         return (
           <>
             {secondaryEntityName} <EventLink event={e} to="secondaryEntity" />{' '}