Skip to content

Commit beb6964

Browse files
pbalcerpbalcer
authored
[UR] add missing validation layer checks for exp enqueue functions (intel#18195)
Found by coverity. Signed-off-by: Piotr Balcer <[email protected]>
1 parent 35a49b6 commit beb6964

File tree

5 files changed

+76
-4
lines changed

5 files changed

+76
-4
lines changed

‎unified-runtime/include/ur_api.h‎

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎unified-runtime/scripts/core/exp-async-alloc.yml‎

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,10 @@ returns:
173173
- $X_RESULT_ERROR_OUT_OF_RESOURCES
174174
- $X_RESULT_ERROR_INVALID_NULL_HANDLE
175175
- $X_RESULT_ERROR_INVALID_NULL_POINTER
176-
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST
176+
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST:
177+
- "`phEventWaitList == NULL && numEventsInWaitList > 0`"
178+
- "`phEventWaitList != NULL && numEventsInWaitList == 0`"
179+
- "If event objects in phEventWaitList are not valid events."
177180

178181
--- #--------------------------------------------------------------------------
179182
type: function
@@ -211,7 +214,10 @@ returns:
211214
- $X_RESULT_ERROR_OUT_OF_RESOURCES
212215
- $X_RESULT_ERROR_INVALID_NULL_HANDLE
213216
- $X_RESULT_ERROR_INVALID_NULL_POINTER
214-
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST
217+
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST:
218+
- "`phEventWaitList == NULL && numEventsInWaitList > 0`"
219+
- "`phEventWaitList != NULL && numEventsInWaitList == 0`"
220+
- "If event objects in phEventWaitList are not valid events."
215221

216222
--- #--------------------------------------------------------------------------
217223
type: function
@@ -250,7 +256,10 @@ returns:
250256
- $X_RESULT_ERROR_OUT_OF_HOST_MEMORY
251257
- $X_RESULT_ERROR_INVALID_NULL_HANDLE
252258
- $X_RESULT_ERROR_INVALID_NULL_POINTER
253-
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST
259+
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST:
260+
- "`phEventWaitList == NULL && numEventsInWaitList > 0`"
261+
- "`phEventWaitList != NULL && numEventsInWaitList == 0`"
262+
- "If event objects in phEventWaitList are not valid events."
254263

255264
--- #--------------------------------------------------------------------------
256265
type: function
@@ -283,7 +292,10 @@ returns:
283292
- $X_RESULT_ERROR_OUT_OF_HOST_MEMORY
284293
- $X_RESULT_ERROR_INVALID_NULL_HANDLE
285294
- $X_RESULT_ERROR_INVALID_NULL_POINTER
286-
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST
295+
- $X_RESULT_ERROR_INVALID_EVENT_WAIT_LIST:
296+
- "`phEventWaitList == NULL && numEventsInWaitList > 0`"
297+
- "`phEventWaitList != NULL && numEventsInWaitList == 0`"
298+
- "If event objects in phEventWaitList are not valid events."
287299

288300
--- #--------------------------------------------------------------------------
289301
type: function

‎unified-runtime/source/loader/layers/validation/ur_valddi.cpp‎

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎unified-runtime/source/loader/ur_libapi.cpp‎

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎unified-runtime/source/ur_api.cpp‎

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)