Skip to content

Commit 1fb9029

Browse files
committed
Hewill provides improved P/R
1 parent 346e759 commit 1fb9029

File tree

1 file changed

+40
-3
lines changed

1 file changed

+40
-3
lines changed

xml/issue4166.xml

Lines changed: 40 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,8 @@ mentioning this point.
6060
A similar issue had been reported as <iref ref="3385"/>, which was eventually adopted as a C++20 DR. This
6161
DR indicates that LWG approved the decision to require `copyable` in order to model a `common_iterator`.
6262
</p>
63-
</discussion>
6463

65-
<resolution>
64+
<superseded>
6665
<p>
6766
This wording is relative to <paper num="N4993"/>.
6867
</p>
@@ -93,6 +92,44 @@ if constexpr (<ins>(semiregular&lt;iterator_t&lt;<i>maybe-const</i>&lt;<i>is-con
9392
</blockquote>
9493
</blockquote>
9594
</li>
96-
</ol></resolution>
95+
</ol>
96+
</superseded>
97+
98+
<note>2025-03-05; Hewill Kang provides improved wording</note>
99+
</discussion>
100+
101+
<resolution>
102+
<p>
103+
This wording is relative to <paper num="N5001"/>.
104+
</p>
105+
106+
<ol>
107+
<li><p>Modify <sref ref="[range.concat.view]"/> as indicated:</p>
108+
109+
<blockquote>
110+
<pre>
111+
constexpr auto end() const
112+
requires (range&lt;const Views&gt; &amp;&amp; ...) &amp;&amp; <i>concatable</i>&lt;const Views...&gt;;
113+
</pre>
114+
<blockquote>
115+
<p>
116+
-7- <i>Effects</i>: Let <tt><i>is-const</i></tt> be `true` for the const-qualified overload, and `false`
117+
otherwise. Equivalent to:
118+
</p>
119+
<blockquote><pre>
120+
constexpr auto N = sizeof...(Views);
121+
if constexpr (<ins><i>all-forward</i>&lt;<i>is-const</i>, Views...&gt; &amp;&amp;</ins>
122+
common_range&lt;<i>maybe-const</i>&lt;<i>is-const</i>, Views...[N - 1]&gt;&gt;) {
123+
return <i>iterator</i>&lt;<i>is-const</i>&gt;(this, in_place_index&lt;N - 1&gt;,
124+
ranges::end(std::get&lt;N - 1&gt;(<i>views_</i>)));
125+
} else {
126+
return default_sentinel;
127+
}
128+
</pre></blockquote>
129+
</blockquote>
130+
</blockquote>
131+
</li>
132+
</ol>
133+
</resolution>
97134

98135
</issue>

0 commit comments

Comments
 (0)