Skip to content

Commit 2c57b78

Browse files
authored
Merge pull request #454 from hewillk/master
Emphasize runtime if to make PR clearer
2 parents b2e7953 + b2b5d64 commit 2c57b78

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

xml/issue3855.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,11 @@ namespace std::ranges {
143143
[<i>Drafting note:</i>
144144
We can't use <code>if constexpr (ranges::size(<i>i_</i>.<i>parent_</i>-&gt;<i>pattern_</i>) == 0)</code>
145145
here because it is not a constant expression, and it seems more intuitive to just use
146-
<code>ranges::empty</code> which is always well-formed. Note that the PR does not seek the
147-
aggressive optimization that minimizes the instantiation as this is not the intent of the
148-
current design (for example, <code><i>outer-iterator</i>&amp; operator++()</code> can be
149-
specialized for the case where <code>Pattern::size() == 0</code>), library implementations
150-
are free to optimize as it pleases.]
146+
<code>ranges::empty</code> combined with runtime <code>if</code> which is always well-formed.
147+
Note that the PR does not seek the aggressive optimization that minimizes the instantiation as this is
148+
not the intent of the current design (for example, <code><i>outer-iterator</i>&amp; operator++()</code>
149+
can be specialized for the case where <code>Pattern::size() == 0</code> to save some O(1) comparisons),
150+
library implementations are free to optimize as it pleases.]
151151
</p>
152152
</blockquote>
153153

0 commit comments

Comments
 (0)