|
| 1 | +<?xml version='1.0' encoding='utf-8' standalone='no'?> |
| 2 | +<!DOCTYPE issue SYSTEM "lwg-issue.dtd"> |
| 3 | + |
| 4 | +<issue num="4254" status="New"> |
| 5 | +<title><code>stride_view::<i>iterator</i></code> should provide <code>operator-></code></title> |
| 6 | +<section><sref ref="[range.stride.iterator]"/></section> |
| 7 | +<submitter>Hewill Kang</submitter> |
| 8 | +<date>01 May 2025</date> |
| 9 | +<priority>99</priority> |
| 10 | + |
| 11 | +<discussion> |
| 12 | +<p> |
| 13 | +Currently, only <code>filter_view::<i>iterator</i></code> and <code>join_view::<i>InnerIter</i></code> in |
| 14 | +<code><ranges></code> provide <code>operator-></code>, which makes sense since their `operator*` |
| 15 | +simply dereferences the underlying iterator. |
| 16 | +<p/> |
| 17 | +It turns out this is also true for <code>stride_view::<i>iterator</i></code>, suggesting that providing |
| 18 | +<code>operator-></code> does is the intuitive thing to do, e.g. when wrapping pointers, keeping |
| 19 | +<code>operator-></code> valid so that users can continue to use <code>it->foo()</code>. |
| 20 | +<p/> |
| 21 | +There is no reason to give up this convenience because <code>stride_view::<i>iterator</i></code> is intended |
| 22 | +to preserve the nature of the underlying iterator. |
| 23 | +</p> |
| 24 | +</discussion> |
| 25 | + |
| 26 | +<resolution> |
| 27 | +<p> |
| 28 | +This wording is relative to <paper num="N5008"/>. |
| 29 | +</p> |
| 30 | +<ol> |
| 31 | + |
| 32 | +<li><p>Modify <sref ref="[range.stride.iterator]"/> as indicated:</p> |
| 33 | + |
| 34 | +<blockquote> |
| 35 | +<pre> |
| 36 | +namespace std::ranges { |
| 37 | + template<input_range V> |
| 38 | + requires view<V> |
| 39 | + template<bool Const> |
| 40 | + class stride_view<V>::<i>iterator</i> { |
| 41 | + using <i>Parent</i> = <i>maybe-const</i><Const, stride_view>; // <i>exposition only</i> |
| 42 | + using <i>Base</i> = <i>maybe-const</i><Const, V>; // <i>exposition only</i> |
| 43 | + |
| 44 | + iterator_t<<i>Base</i>> <i>current_</i> = iterator_t<<i>Base</i>>(); // <i>exposition only</i> |
| 45 | + sentinel_t<<i>Base</i>> <i>end_</i> = sentinel_t<<i>Base</i>>(); // <i>exposition only</i> |
| 46 | + range_difference_t<<i>Base</i>> <i>stride_</i> = 0; // <i>exposition only</i> |
| 47 | + range_difference_t<<i>Base</i>> <i>missing_</i> = 0; // <i>exposition only</i> |
| 48 | + |
| 49 | + constexpr iterator(<i>Parent</i>* parent, iterator_t<<i>Base</i>> current, // <i>exposition only</i> |
| 50 | + range_difference_t<<i>Base</i>> missing = 0); |
| 51 | + public: |
| 52 | + […] |
| 53 | + |
| 54 | + constexpr decltype(auto) operator*() const { return *<i>current_</i>; } |
| 55 | + <ins>constexpr auto operator->() const |
| 56 | + requires <i>has-arrow</i><iterator_t<<i>Base</i>>> && copyable<iterator_t<<i>Base</i>>> |
| 57 | + { return <i>current_</i>; }</ins> |
| 58 | + |
| 59 | + […] |
| 60 | + }; |
| 61 | +}</pre> |
| 62 | +</blockquote> |
| 63 | +</li> |
| 64 | +</ol> |
| 65 | +</resolution> |
| 66 | + |
| 67 | +</issue> |
0 commit comments