Skip to content

Commit a59be59

Browse files
committed
Improve P/R as noticed by Hewill
1 parent e9a16a5 commit a59be59

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

xml/issue4402.xml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,31 @@ namespace std::simd {
8989
</blockquote>
9090
</li>
9191

92+
<li><p>Modify <sref ref="[simd.overview]"/> as indicated:</p>
93+
94+
<blockquote>
95+
<pre>
96+
namespace std::simd {
97+
template&lt;size_t T, class Abi&gt; class basic_vec {
98+
public:
99+
using value_type = T;
100+
using mask_type = basic_mask&lt;sizeof(T), Abi&gt;;
101+
using abi_type = Abi;
102+
using iterator = <i>simd-iterator</i>&lt;basic_vec&gt;;
103+
using const_iterator = <i>simd-iterator</i>&lt;const basic_vec&gt;;
104+
105+
constexpr iterator begin() noexcept { return <ins>iterator(</ins><del>{</del>*this, 0<del>}</del><ins>)</ins>; }
106+
constexpr const_iterator begin() const noexcept { return <ins>const_iterator(</ins><del>{</del>*this, 0<del>}</del><ins>)</ins>; }
107+
constexpr const_iterator cbegin() const noexcept { return <ins>const_iterator(</ins><del>{</del>*this, 0<del>}</del><ins>)</ins>; }
108+
constexpr default_sentinel_t end() const noexcept { return {}; }
109+
constexpr default_sentinel_t cend() const noexcept { return {}; }
110+
111+
[&hellip;]
112+
};
113+
}
114+
</pre>
115+
</blockquote>
116+
</li>
92117
<li><p>Modify <sref ref="[simd.mask.overview]"/> as indicated:</p>
93118

94119
<blockquote>
@@ -100,6 +125,7 @@ namespace std::simd {
100125
using abi_type = Abi;
101126
using iterator = <i>simd-iterator</i>&lt;basic_mask&gt;;
102127
using const_iterator = <i>simd-iterator</i>&lt;const basic_mask&gt;;
128+
103129
constexpr iterator begin() noexcept { return <ins>iterator(</ins><del>{</del>*this, 0<del>}</del><ins>)</ins>; }
104130
constexpr const_iterator begin() const noexcept { return <ins>const_iterator(</ins><del>{</del>*this, 0<del>}</del><ins>)</ins>; }
105131
constexpr const_iterator cbegin() const noexcept { return <ins>const_iterator(</ins><del>{</del>*this, 0<del>}</del><ins>)</ins>; }

0 commit comments

Comments
 (0)