Use string::starts_with

Author: jwakely

src/list_issues.cpp

@@ -61,7 +61,7 @@ auto read_file_into_string(fs::path const & filename) -> std::string {
 auto is_issue_xml_file(fs::directory_entry const & e) {
    if (e.is_regular_file()) {
       fs::path f = e.path().filename();
-      return f.string().compare(0, 5, "issue") == 0 && f.extension() == ".xml";
+      return f.string().starts_with("issue") && f.extension() == ".xml";
    }
    return false;
 }

src/lists.cpp

@@ -73,7 +73,7 @@ auto read_file_into_string(fs::path const & filename) -> std::string {
 auto is_issue_xml_file(fs::directory_entry const & e) {
    if (e.is_regular_file()) {
       fs::path f = e.path().filename();
-      return f.string().compare(0, 5, "issue") == 0 && f.extension() == ".xml";
+      return f.string().starts_with("issue") && f.extension() == ".xml";
    }
    return false;
 }

src/sections.cpp

@@ -180,7 +180,7 @@ auto lwg::format_section_tag_as_link(section_map & section_db, section_tag const
    std::string url;
    if  (!tag.prefix.empty()) {
       std::string_view fund_ts = "fund.ts";
-      if (tag.prefix.compare(0, fund_ts.size(), fund_ts) == 0) {
+      if (tag.prefix.starts_with(fund_ts)) {
          std::string_view version = tag.prefix;
          version.remove_prefix(fund_ts.size());
          if (version.empty())

src/status.cpp

@@ -73,9 +73,7 @@ auto lwg::is_closed(std::string_view stat) -> bool {
 }
 
 auto lwg::is_tentative(std::string_view stat) -> bool {
-   // a more efficient implementation will use some variation of strcmp
-   std::string_view tent{"Tentatively"};
-   return 0 == stat.compare(0, tent.size(), tent);
+   return stat.starts_with("Tentatively");
 }
 
 auto lwg::is_assigned_to_another_group(std::string_view stat) -> bool {
@@ -104,7 +102,7 @@ auto lwg::is_ready(std::string_view stat) -> bool {
 // Functions to "normalize" a status string
 namespace {
 auto remove_prefix(std::string_view str, std::string_view prefix) -> std::string_view {
-   if (0 == str.compare(0, prefix.size(), prefix)) {
+   if (str.starts_with(prefix)) {
       str.remove_prefix(prefix.size() + 1);
    }
    return str;