File tree Expand file tree Collapse file tree 1 file changed +6
-3
lines changed
Expand file tree Collapse file tree 1 file changed +6
-3
lines changed Original file line number Diff line number Diff line change @@ -26,13 +26,16 @@ is false.
2626<p >
2727It seems like we should require `is_move_constructible_v` instead,
2828and only if the allocator traits mean we need to construct an object.
29+ (Technically move-constructible might not be correct, because the allocator's
30+ `construct` member might use a different constructor).
2931</p >
3032<p >
3133Additionally, the noexcept-specifier for the move assignment doesn't match
3234the effects. The noexcept-specifier says it can't throw if POCMA is true,
33- but nothing in the effects says that ownership can be transferred in that case.
34- We only do a non-throwing transfer when the allocators are equal.
35- I think we should also transfer ownership when
35+ but nothing in the effects says that ownership can be transferred in that case;
36+ we only do a non-throwing transfer when the allocators are equal.
37+ I think we <i >should</i > transfer ownership when POCMA is true,
38+ which would make the noexcept-specifier correct.
3639</p >
3740</discussion >
3841
You can’t perform that action at this time.
0 commit comments