Centralize metadata reading to handle non-default paths #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I guess this means we need to extend bin/build_pgms as well. |
Member
Do you use that? I would prefer if we only had to update the makefile. |
jwakely
approved these changes
Nov 2, 2024
Member
Yes. But I can add the additional file myself if I'm the only one. |
Member
See #440 |
Member
Yeah, sorry, I missed that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/liststakes an optional path argument and reads issues andmeta-data/section.datarelative to that path instead of the current path.meta-data/datesandmeta-data/paper_titles.txt, however, are always read relative to the current path. So when using a non-default path the generation still mostly works, but you get wrong dates and no paper titles :(This PR consolidates all the metadata into one class that can be extended if needed, and ensures that they are all read relative to the provided path.