Add CMakeLists.txt #450
Closed
Add CMakeLists.txt #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
commented
Nov 18, 2024
jwakely
approved these changes
Nov 18, 2024
Member
jwakely
left a comment
jwakely
left a comment
There was a problem hiding this comment.
This seems fine as is, but if you want to reformat the lint.sh that's fine too.
Author
Reformatted. Please squash merge, I CBA to cleanup the fixup commits. |
jwakely
approved these changes
Nov 18, 2024
Dani-Hub
approved these changes
Nov 21, 2024
Member
|
Rebased with fixups and pushed as d5afd6e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the horribly bit-rotted Visual Studio projects with a modern CMake build system. The CMake build can't yet do everything the Makefile build does, which is fine: the goal isn't to replace it, but to have a working MSVC build.
This shouldn't be destabilizing: the only interaction with the Makefile build/CI is the bash script to run xmllint, which is well tested. It should be safe to apply during the meeting.