forked from lwg/issues
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue from Dietmar Kühl: affine_on has no specification for the d… #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?xml version='1.0' encoding='utf-8' standalone='no'?> | ||
| <!DOCTYPE issue SYSTEM "lwg-issue.dtd"> | ||
|
|
||
| <issue num="4344" status="New"> | ||
| <title><code>affine_on</code> has no specification for the default</title> | ||
| <section><sref ref="[exec.affine.on]"/></section> | ||
| <submitter>Dietmar Kühl</submitter> | ||
| <date>01 Sep 2025</date> | ||
| <priority>99</priority> | ||
|
|
||
| <discussion> | ||
| <p> | ||
| The wording of <code>affine_on</code> doesnt have a specification | ||
| for the default implementation. For other algorithms the default | ||
| implementation is specified. | ||
| </p> | ||
| <p> | ||
| The intention for <code>affine_on</code> was to all | ||
| optimisation/customisation in a way reducing the necessary scheduling: | ||
| if the implementation can determine if a sender completed already | ||
| on the correct execution agent it should be allowed to avoid | ||
| scheduling. A specification should provide enough lattitude to | ||
| allow that. | ||
| </p> | ||
| </discussion> | ||
|
|
||
| <resolution> | ||
| <p> | ||
| Add a new paragraph to the specification of <code>affine_on</code> | ||
| in <a href="https://wg21.link/exec.affine.on">[exec.affine.on]</a> providing | ||
| a specification for the default implementation: | ||
| </p> | ||
| <p> | ||
| <blockquote> | ||
| <p><ins> | ||
| -6- Let <code>sndr</code> and <code>env</code> be subexpressions | ||
| such that <code>Sndr</code> is <code>decltype((sndr))</code>. If | ||
| <code>sender-for<Sndr, affine_on_t></code> is <code>false</code>, then the expression | ||
| <code>affine_on.transform_sender(sndr, env)</code> is ill-formed; otherwise, it | ||
| is equivalent to: | ||
| </ins> | ||
| </p> | ||
| <pre> | ||
| <ins> | ||
| auto [_, sch, child] = sndr; | ||
| return transform_sender( | ||
| <i>query-with-default</i>(get_domain, sch, default_domain()), | ||
| continues_on(std::move(child), std::move(sch))); | ||
| </ins> | ||
| </pre> | ||
| <p><ins>except that <code>sch</code> is only evaluated once. </ins></p> | ||
| </blockquote> | ||
| </p> | ||
| </resolution> | ||
|
|
||
| </issue> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.