[rand.req.seedeq], [rand.req.dist], [char.traits.require] Eliminate "compile-time" complexity #6839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisenwave
changed the title
eisenwave
changed the title
Contributor
|
@jwakely, @jensmaurer: I'm sympathetic to improving this, but can we do better than just deleting "compile-time"? Can we maybe say something along the lines of something being constant-evaluated? |
Member
|
@tkoeppe, these are typedefs. There is no evaluation going on at all, not even constant evaluation. We should just merge this. |
jensmaurer
approved these changes
Jul 31, 2024
Member
|
Suggest to improve commit descriptions to say "... for typedefs" |
Contributor
|
OK, makes sense. @eisenwave Could you please update the commit messages? Also please just say "remove" instead of the overly lyrical "eliminate". |
Member
Author
|
I'm on vacation. If it's not urgent, I can do it in two weeks when I'm back. |
Contributor
|
@eisenwave Ping 🌴 |
eisenwave
force-pushed
the
compile-time-complexity
branch
from
ad0f50d to
2bd2de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5641.
In short, the C++ standard doesn't have a clearly-defined notion of "compile-time" or "run-time".
Instead of specifying that these type aliases have "compile-time complexity" (whatever that's supposed to mean) we can just leave the cell empty. No evaluation takes place here, so it's meaningless to talk about complexity.