[2025-02 CWG Motion 9] P1967R14 #embed
#7704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisdairM
changed the title
#embed
AlisdairM
force-pushed
the
p1967_embed
branch
3 times, most recently
from
d2e8b8f to
963aadc
Compare
AlisdairM
changed the title
#embed#embed
eisenwave
reviewed
Feb 20, 2025
eisenwave
reviewed
Feb 20, 2025
eisenwave
reviewed
Feb 20, 2025
eisenwave
reviewed
Feb 20, 2025
eisenwave
reviewed
Feb 20, 2025
eisenwave
reviewed
Feb 20, 2025
AlisdairM
force-pushed
the
p1967_embed
branch
4 times, most recently
from
d9b7453 to
aece602
Compare
Contributor
|
Can we add has-embed-expressions to this list despite it being a change missing in the paper? Lines 542 to 547 in aece602 Or do we need @jensmaurer to create a new Core Issue? |
cpplearner
reviewed
Feb 21, 2025
Member
|
I think the change suggested by @hubert-reinterpretcast is editorial; this is part of the necessary evaluation semantics. Please add in a separate commit with the "[label] title" description style. |
jensmaurer
requested changes
Feb 21, 2025
AlisdairM
force-pushed
the
p1967_embed
branch
2 times, most recently
from
c2db747 to
fb206cd
Compare
Contributor
Author
|
This PR is still showing as "changes requested". I believe I have addressed all issues, could someone point out where I have missed, or remove the status? |
jensmaurer
approved these changes
Mar 11, 2025
tkoeppe
force-pushed
the
p1967_embed
branch
5 times, most recently
from
86c6128 to
af326e1
Compare
Editorial notes: * Redistributed grammar around the preamble to better maintain a locality and flow. * Minor grammar tweak: "other than a" -> "except:".
Following the style of the equivalent paragraph introduced with the `embed` wording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7659.
Also fixes cplusplus/papers#700.
Redistributed grammar around the preamble to better maintain a locality and flow. More redistrubution expected in a follow-up commit.
Minor grammar tweak: "other than a" -> "except:"
following the model of such specifications in
basic-s-char and elsewhere.
Attempted to describe all implementation-defined
topics for the index, but will need review.