Skip to content

[polymorphic.general] Fix paragraph 3 #7820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jensmaurer merged 1 commit into from
Apr 10, 2025
Merged

[polymorphic.general] Fix paragraph 3 #7820

jensmaurer merged 1 commit into from
Apr 10, 2025

Conversation

@xmcgcg
Copy link
Contributor

@xmcgcg xmcgcg commented Apr 10, 2025

[polymorphic.general] paragraph 3 has a broken expression allocator_traits<Allocator>::cop, args...). It should be the same expression used in [indirect.general].

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Apr 10, 2025

The produced PDF (P3019R14) was broken and it was very strange that nobody discovered this in #7708.

allocator_traits<Allocator>::construct(a, p, args...) is probably correct per https://github.com/jbcoe/value_types/blob/9f32f207fb569da17e644f65c7b9568cc387026f/DRAFT.md#xz1-class-template-polymorphic-general-polymorphicgeneral.

@jensmaurer jensmaurer merged commit a989431 into cplusplus:main Apr 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xmcgcg @frederick-vs-ja @jwakely @jensmaurer