P2843R3 Preprocessing is never undefined #7981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisenwave
suggested changes
Jun 23, 2025
AlisdairM
force-pushed
the
apply_p2843_ub_in_preprocessor
branch
from
ac8c09e to
c35929a
Compare
eisenwave
reviewed
Jun 24, 2025
AlisdairM
force-pushed
the
apply_p2843_ub_in_preprocessor
branch
from
c35929a to
184a5c3
Compare
Contributor
Author
|
@eisenwave Rewrote history to correctly handle removing the circular reference as a subsequent edit. Undid the paragraph breakdown, replacing with the single semantic line break that you suggested. |
Member
|
That looks about right now, but the commit for adding a semantic line break isn't really necessary. That could just be a drive-by fix in the main commit since it doesn't alter the rendered output in any way. I'm fine with all the other stuff, but I suspect @tkoeppe may want that last commit yoinked out. |
eisenwave
approved these changes
Jun 24, 2025
tkoeppe
force-pushed
the
apply_p2843_ub_in_preprocessor
branch
2 times, most recently
from
53bcb76 to
c0763e4
Compare
Editorial notes: * [cpp.replace] Removed circular reference * Wording reconciled with resolution of CWG3015
tkoeppe
force-pushed
the
apply_p2843_ub_in_preprocessor
branch
from
c0763e4 to
d9555c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7937
Fixes cplusplus/papers#1548
Also fixes cplusplus/papers#1409
Also fixes cplusplus/papers#1410
Also fixes cplusplus/papers#1411