[cmp.common] Remove unnecessary "std::" before strong_ordering #8148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a note, I don't think it's a problem to qualify it. I don't really care about this either way. |
|
I think it depends a bit on whether we have ambitions for the aforementioned checks. The reason I've paid attention to it in the first place is because I've accidentally used So maybe there's value in ensuring such issues don't sneak their way into the standard, on the off chance that LWG doesn't catch them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my search, this is the only occurrence of
std::beforestrong_ordering,partial_ordering, orweak_orderingin library wording.Now thinking about it, we could perhaps make a check that generally disallows
std::except for certain whitelisted files (where there are too many violations to fix) and symbols (likestd::move).