Merge pull request #141 from cporcellijr/fix/remove-storyteller-fallback

* [Fix] Remove Storyteller fallback collection logic

* [Fix] Optimize SyncManager self-healing logic

Author: cporcellijr

src/sync_manager.py

@@ -1077,10 +1077,7 @@ def _sync_cycle_internal(self, target_abs_id=None):
 
             try:
                 # -----------------------------------------------------------------
-                # SPARSE MAP DETECTOR (Self-Healing)
-                # If a book was aligned under the old N=12 logic, it might have
-                # sparse anchors. This forces them back to the background queue
-                # to get a dense Pass 3/4 map without blocking the UI cycle.
+                # MIGRATION UPGRADE
                 # -----------------------------------------------------------------
                 if self.alignment_service:
                     alignment = self.alignment_service._get_alignment(abs_id)
@@ -1091,24 +1088,6 @@ def _sync_cycle_internal(self, target_abs_id=None):
                             book.transcript_file = 'DB_MANAGED'
                             self.database_service.save_book(book)
 
-                        if len(alignment) > 2:
-                            last_ts = float(alignment[-1].get('ts', 0))
-                            anchor_count = len(alignment)
-                            avg_gap = last_ts / anchor_count if anchor_count > 0 else 0
-                            
-                            if avg_gap > 45.0:
-                                logger.info(f"   🩹 Self-Healing: Sparse alignment map detected (avg gap {avg_gap:.1f}s). Queuing for dense re-processing.")
-                                book.status = 'pending'
-                                self.database_service.save_book(book)
-                                continue
-                    else:
-                        # Alignment map is completely missing
-                        if getattr(book, 'sync_mode', 'audiobook') != 'ebook_only':
-                            logger.info(f"   🩹 Self-Healing: Missing alignment map detected for '{title_snip}'. Queuing for deep anchoring.")
-                            book.status = 'pending'
-                            self.database_service.save_book(book)
-                            continue
-
                 # Get previous state for this book from database
                 previous_states = self.database_service.get_states_for_book(abs_id)
 
@@ -1262,6 +1241,15 @@ def _sync_cycle_internal(self, target_abs_id=None):
                 # At this point we have a significant change to act on
                 logger.info(f"🔄 '{abs_id}' '{title_snip}' Change detected")
 
+                # [NEW] Missing Map Check (Deep Anchoring)
+                # Only heal if progress is actively happening to avoid unnecessary processing
+                if getattr(book, 'sync_mode', 'audiobook') != 'ebook_only':
+                    if self.alignment_service and not self.alignment_service._get_alignment(abs_id):
+                        logger.info(f"   🩹 Self-Healing: Missing deep anchoring map detected after progress on '{title_snip}'. Queuing for processing.")
+                        book.status = 'pending'
+                        self.database_service.save_book(book)
+                        continue
+
                 # Status block - show only changed lines
                 status_lines = []
                 for key, cfg in config.items():

src/web_server.py

@@ -1333,9 +1333,6 @@ def match():
         if container.storyteller_client().is_configured():
             if book.storyteller_uuid:
                 container.storyteller_client().add_to_collection_by_uuid(book.storyteller_uuid)
-            else:
-                fallback_name = original_ebook_filename or ebook_filename
-                container.storyteller_client().add_to_collection(fallback_name)
 
         # Auto-dismiss any pending suggestion for this book
         # Need to dismiss by BOTH abs_id (audiobook-triggered) and kosync_doc_id (ebook-triggered)
@@ -1498,9 +1495,6 @@ def batch_match():
                 if container.storyteller_client().is_configured():
                     if book.storyteller_uuid:
                         container.storyteller_client().add_to_collection_by_uuid(book.storyteller_uuid)
-                    else:
-                        fallback_name = original_ebook_filename or ebook_filename
-                        container.storyteller_client().add_to_collection(fallback_name)
 
                 # Auto-dismiss any pending suggestion
                 database_service.dismiss_suggestion(item['abs_id'])

tests/test_webserver.py

@@ -439,7 +439,7 @@ def test_match_endpoint_with_clean_di(self):
 
             self.mock_abs_client.add_to_collection.assert_called_once_with('test-audiobook-123', 'Synced with KOReader')
             self.mock_booklore_client.add_to_shelf.assert_called_once_with('test-book.epub', 'Kobo')
-            self.mock_storyteller_client.add_to_collection.assert_called_once_with('test-book.epub')
+            self.mock_storyteller_client.add_to_collection.assert_not_called()
 
             print("[OK] Match endpoint test passed with clean DI")