fix mh metric issues

Author: Remi-Gau

manualTests/miss_hit.cfg

@@ -1,3 +1,10 @@
+# style guide (https://florianschanda.github.io/miss_hit/style_checker.html)
 line_length: 100
 regex_function_name: "((test_[a-z]+)|[a-z]+)(([A-Z]){1}[A-Za-z]+)*"
-suppress_rule: "copyright_notice"
+suppress_rule: "copyright_notice"
+
+# metrics limit for the code quality (https://florianschanda.github.io/miss_hit/metrics.html)
+metric "cnest": limit 4
+metric "file_length": limit 500
+metric "cyc": limit 15
+metric "parameters": limit 5

miss_hit.cfg

@@ -1,4 +1,4 @@
-# styly guide (https://florianschanda.github.io/miss_hit/style_checker.html)
+# style guide (https://florianschanda.github.io/miss_hit/style_checker.html)
 line_length: 100
 regex_function_name: "[a-z]+(([A-Z]){1}[A-Za-z]+)*"
 suppress_rule: "copyright_notice"

tests/miss_hit.cfg

@@ -1,3 +1,10 @@
+# style guide (https://florianschanda.github.io/miss_hit/style_checker.html)
 line_length: 100
 regex_function_name: "((test_[a-z]+)|[a-z]+)(([A-Z]){1}[A-Za-z]+)*"
-suppress_rule: "copyright_notice"
+suppress_rule: "copyright_notice"
+
+# metrics limit for the code quality (https://florianschanda.github.io/miss_hit/metrics.html)
+metric "cnest": limit 4
+metric "file_length": limit 500
+metric "cyc": limit 15
+metric "parameters": limit 5

tests/test_setTargetPositionInSequence.m

@@ -1,7 +1,7 @@
 function test_suite = test_setTargetPositionInSequence %#ok<*STOUT>
-
+    
     initEnv();
-
+    
     try % assignment of 'localfunctions' is necessary in Matlab >= 2016
         test_functions = localfunctions(); %#ok<*NASGU>
     catch % no problem; early Matlab versions can use initTestSuite fine
@@ -10,68 +10,63 @@
 end
 
 function test_setTargetPositionInSequenceBasic()
-
+    
     seqLength = 12;
     nbTarget = 3;
     forbiddenPos = [1 5 10];
-
+    
     % Create a hundred draws of targer positiona and ensure that
     % - the forbidden position are never drawn
     % - the interval between target is superior to 1
     for i = 1:100
         chosenPositions(i, :) = setTargetPositionInSequence(seqLength, nbTarget, forbiddenPos);
     end
-
+    
     assertFalse(any(ismember(chosenPositions(:), forbiddenPos)));
-
+    
     interval = abs(diff(chosenPositions, [], 2));
     assertTrue(all(interval(:) > 1));
-
+    
 end
 
 function initEnv
-
-    octaveVersion = '4.0.3';
-    matlabVersion = '8.6.0';
-
-    installlist = {'io', 'statistics', 'image'};
-
+    
+    installlist = {'io', 'statistics'};
+    
     if isOctave
-
-        % Exit if min version is not satisfied
-        if ~compare_versions(OCTAVE_VERSION, octaveVersion, '>=')
-            error('Minimum required Octave version: %s', octaveVersion);
-        end
-
+        
         for ii = 1:length(installlist)
+            
+            packageName = installlist{ii};
+            
             try
                 % Try loading Octave packages
-                disp(['loading ' installlist{ii}]);
-                pkg('load', installlist{ii});
-
+                disp(['loading ' packageName]);
+                pkg('load', packageName);
+                
             catch
-                errorcount = 1;
-                while errorcount % Attempt twice in case installation fails
-                    try
-                        pkg('install', '-forge', installlist{ii});
-                        pkg('load', installlist{ii});
-                        errorcount = 0;
-                    catch err
-                        errorcount = errorcount + 1;
-                        if errorcount > 2
-                            error(err.message);
-                        end
-                    end
-                end
+                tryInstallFromForge(packageName);
             end
         end
+        
+    end
+    
+end
 
-    else % MATLAB ----------------------------
-
-        if verLessThan('matlab', matlabVersion)
-            error('Sorry, minimum required version is R2017b. :(');
+function tryInstallFromForge(packageName)
+    
+    errorcount = 1;
+    while errorcount % Attempt twice in case installation fails
+        try
+            pkg('install', '-forge', packageName);
+            pkg('load', packageName);
+            errorcount = 0;
+        catch err
+            errorcount = errorcount + 1;
+            if errorcount > 2
+                error(err.message);
+            end
         end
-
     end
-
+    
 end