refactor

Author: Remi-Gau

miss_hit.cfg

@@ -16,5 +16,5 @@ tab_width: 2
 # metrics limit for the code quality (https://florianschanda.github.io/miss_hit/metrics.html)
 metric "cnest": limit 4
 metric "file_length": limit 400
-metric "cyc": limit 23
+metric "cyc": limit 16
 metric "parameters": limit 7

src/roi/plotDataInRoi.m

@@ -29,6 +29,14 @@
   % :param dataLabel: strings to use to label the data rows or columns.
   % :type dataLabel: cellstr
   %
+  % :param maxVox: max of scale for nb of voxels. Default to [].
+  % :type maxVox: positive integer
+  %
+  % :param nbBins: use the same number of bins for all graphs.
+  %                By default based on the number of unique values across all
+  %                the datasets.
+  % :type nbBins: positive integer
+  %
   %
   % EXAMPLE::
   %
@@ -58,6 +66,8 @@
   args.addParameter('scaleFactor', 1, @isnumeric);
   args.addParameter('roiAs', 'rows', rowOrCol);
   args.addParameter('dataLabel', {}, @iscellstr);
+  args.addParameter('maxVox', [], @isnumeric);
+  args.addParameter('nbBins', [], @isnumeric);
 
   args.parse(varargin{:});
 
@@ -66,6 +76,7 @@
   scaleFactor = args.Results.scaleFactor;
   roiAs = args.Results.roiAs;
   dataLabel = args.Results.dataLabel;
+  nbBins = args.Results.nbBins;
 
   if ischar(dataImages)
     dataImages = {dataImages};
@@ -95,17 +106,12 @@
 
   %% collect info to adapt the graphs later on
 
-  % max of scale for data values
-  maxVox = [];
+  nbBinsList = [];
 
-  % limit axis of axis for ROI (as nb of voxels)
+  % limit axis of axis for ROI (nb of voxels)
   MIN = [];
   MAX = [];
 
-  % use the same number of bins for all graphs
-  % based on the number of unique values across all the datasets
-  nbBins = [];
-
   % to plot all the modes
   modes = [];
 
@@ -133,7 +139,7 @@
 
       % modes and nbBins work better on rounded values
       modes(end + 1) = mode(round(data{idxSubplot}));
-      nbBins(end + 1) = numel(unique(round(data{idxSubplot})));
+      nbBinsList(end + 1) = numel(unique(round(data{idxSubplot})));
 
       subplotList(iRow, iCol) = idxSubplot;
 
@@ -143,17 +149,12 @@
 
   end
 
-  nbBins = max(nbBins);
-
-  for i = 1:numel(data)
-    tmp = hist(data{i}, nbBins);
-    if isempty(tmp)
-      maxVox(end + 1) = nan;
-    else
-      maxVox(end + 1) = max(tmp);
-    end
+  if isempty(nbBins)
+    nbBins = max(nbBinsList);
   end
 
+  maxVox = getMaxVox(args, data);
+
   %% plot histogram and mode
 
   idxSubplot = 1;
@@ -191,7 +192,11 @@
 
   end
 
-  %% label axis
+  labelAxis(roiAs, rows, cols, subplotList, roiImages, dataLabel);
+
+end
+
+function labelAxis(roiAs, rows, cols, subplotList, roiImages, dataLabel)
 
   if strcmp(roiAs, 'rows')
 
@@ -241,3 +246,25 @@
   end
 
 end
+
+function maxVox = getMaxVox(args, data)
+
+  maxVox = args.Results.maxVox;
+
+  if isempty(maxVox)
+
+    for i = 1:numel(data)
+
+      tmp = hist(data{i}, nbBins);
+
+      if isempty(tmp)
+        maxVox(end + 1) = nan;
+      else
+        maxVox(end + 1) = max(tmp);
+      end
+
+    end
+
+  end
+
+end