Skip to content

Commit 80ac4a9

Browse files
committed
fix test pollution in test batches
1 parent d9eeb94 commit 80ac4a9

File tree

5 files changed

+9
-18
lines changed

5 files changed

+9
-18
lines changed

.github/workflows/check_md_links.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ jobs:
2323
with:
2424
use-quiet-mode: 'yes'
2525
use-verbose-mode: 'yes'
26-
config-file: 'mlc_config.json'
26+
config-file: '.github/workflows/mlc_config.json'

.github/workflows/mlc_config.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"ignorePatterns": [
3+
{
4+
"pattern": "^https://www.fil.ion.ucl.ac.uk/spm"
5+
}
6+
]
7+
}

tests/tests_batches/stats/test_setBatchFactorialDesign.m

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010

1111
function test_setBatchFactorialDesign_within_group()
1212

13-
% createDummyData();
14-
1513
opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
1614

1715
opt.model.file = spm_file(opt.model.file, ...
@@ -33,8 +31,6 @@ function test_setBatchFactorialDesign_within_group()
3331

3432
function test_setBatchFactorialDesign_complex()
3533

36-
% createDummyData();
37-
3834
opt = setOptions('vismotion', {'01' 'ctrl01'}, 'pipelineType', 'stats');
3935

4036
opt.model.file = spm_file(opt.model.file, ...
@@ -79,8 +75,6 @@ function test_setBatchFactorialDesign_complex()
7975

8076
function test_setBatchFactorialDesign_basic()
8177

82-
% createDummyData();
83-
8478
opt = setOptions('vismotion', {'01' 'ctrl01'}, 'pipelineType', 'stats');
8579

8680
datasetNode = opt.model.bm.get_nodes('Level', 'dataset');

tests/tests_batches/stats/test_setBatchSubjectLevelGLMSpec.m

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ function test_setBatchSubjectLevelGLMSpec_vismotion_acq_1pt6acq()
3535
[~, dir] = fileparts(matlabbatch{1}.spm.stats.fmri_spec.dir{1});
3636
assertEqual(dir, 'task-vismotion_acq-1p60mm_space-IXI549Space_FWHM-6');
3737

38-
cleanUp(fullfile(pwd, 'derivatives'));
39-
4038
end
4139

4240
function test_setBatchSubjectLevelGLMSpec_brain_mask()
@@ -58,8 +56,6 @@ function test_setBatchSubjectLevelGLMSpec_brain_mask()
5856
assertEqual(spm_file(matlabbatch{1}.spm.stats.fmri_spec.mask, 'filename'), ...
5957
{'sub-01_ses-01_space-IXI549Space_desc-brain_mask.nii'});
6058

61-
cleanUp(fullfile(pwd, 'derivatives'));
62-
6359
end
6460

6561
function test_setBatchSubjectLevelGLMSpec_missing_raw_data()
@@ -136,8 +132,6 @@ function test_setBatchSubjectLevelGLMSpec_basic()
136132
assertEqual(matlabbatch{1}.spm.stats.fmri_spec.timing.units, 'secs');
137133
assertEqual(matlabbatch{1}.spm.stats.fmri_spec.timing.RT, 1.55);
138134

139-
cleanUp(fullfile(pwd, 'derivatives'));
140-
141135
end
142136

143137
function test_setBatchSubjectLevelGLMSpec_slicetiming_metadata()
@@ -161,8 +155,6 @@ function test_setBatchSubjectLevelGLMSpec_slicetiming_metadata()
161155
assertEqual(matlabbatch{1}.spm.stats.fmri_spec.timing.fmri_t, 14);
162156
assertEqual(matlabbatch{1}.spm.stats.fmri_spec.timing.fmri_t0, 7);
163157

164-
cleanUp(fullfile(pwd, 'derivatives'));
165-
166158
end
167159

168160
function test_setBatchSubjectLevelGLMSpec_inconsistent_metadata()
@@ -214,6 +206,6 @@ function test_setBatchSubjectLevelGLMSpec_design_only()
214206
assertEqual(matlabbatch{1}.spm.stats.fmri_design.cvi, 'FAST');
215207
assertEqual(matlabbatch{1}.spm.stats.fmri_design.bases.hrf.derivs, [1 0]);
216208

217-
cleanUp(fullfile(pwd, 'derivatives'));
209+
createDummyData();
218210

219211
end

tests/tests_batches/stats/test_setBatchSubjectLevelResults.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010

1111
function test_setBatchSubjectLevelResults_basic()
1212

13-
% createDummyData();
14-
1513
% IF
1614
contrast_name = 'VisMot';
1715
[subLabel, opt, result] = setUp('vismotion', contrast_name);

0 commit comments

Comments
 (0)