fix test pollution

Author: Remi-Gau

src/batches/preproc/setBatchCreateVDMs.m

@@ -54,7 +54,7 @@
 
       metadata = bids.query(BIDS, 'metadata', filter);
 
-      if strfind(metadata.IntendedFor, opt.taskName)
+      if any(strfind(metadata.IntendedFor, opt.taskName))
 
         try
           [echotimes, isEPI, totReadTime, blipDir] = getMetadataForVDM(BIDS, filter);

src/messages/createUnorderedList.m

@@ -40,6 +40,13 @@
       if ~iscell(content)
         content = {content};
       end
+
+      for j = 1:numel(content)
+        if isnumeric(content{j})
+          content{j} = num2str(content{j});
+        end
+      end
+
       output = [output prefix fields{i} ': {' strjoin(content, ', ') '}'];
     end
 

tests/tests_batches/preproc/test_setBatchSmoothConImages.m

@@ -10,8 +10,6 @@
 
 function test_setBatchSmoothConImages_basic()
 
-  % createDummyData();
-
   opt = setOptions('vismotion', {'01', 'blind01'}, 'pipelineType', 'stats');
 
   opt.fwhm.contrast = 6;

tests/tests_batches/stats/test_setBatchSubjectLevelResults.m

@@ -89,8 +89,6 @@ function test_setBatchSubjectLevelResults_error_no_matching_contrast()
 
 function [subLabel, opt, result] = setUp(task, contrastName)
 
-  % createDummyData();
-
   iCon = 1;
 
   subLabel = '01';

tests/tests_batches/test_setBatchMeanAnatAndMask.m

@@ -10,8 +10,6 @@
 
 function test_setBatchMeanAnatAndMask_basic()
 
-  % createDummyData();
-
   opt = setOptions('vismotion', {'01', 'ctrl01'}, 'pipelinetype', 'stats');
 
   matlabbatch = {};

tests/tests_workflows/stats/test_bidsFFX.m

@@ -70,8 +70,6 @@ function test_bidsFFX_skip_subject_no_data()
 
 function test_bidsFFX_contrasts_select_node()
 
-  % createDummyData();
-
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
   opt.stc.skip = 1;
 
@@ -84,8 +82,6 @@ function test_bidsFFX_contrasts_select_node()
 
 function test_bidsFFX_contrasts()
 
-  % createDummyData();
-
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
   opt.stc.skip = 1;
 
@@ -129,6 +125,8 @@ function test_bidsFFX_fmriprep_no_smoothing()
 
   cleanUp(opt.dir.preproc);
 
+  createDummyData();
+
 end
 
 function test_bidsFFX_mni()
@@ -157,6 +155,6 @@ function test_bidsFFX_mni()
 
   end
 
-  % createDummyData();
+  createDummyData();
 
 end

tests/tests_workflows/stats/test_bidsModelSelection.m

@@ -14,8 +14,6 @@
 
 function test_bidsModelSelection_basic()
 
-  % createDummyData();
-
   % GIVEN
   opt = setOptions('vislocalizer');
   opt = rmfield(opt, 'taskName');
@@ -45,8 +43,6 @@ function test_bidsModelSelection_basic()
 
 function test_bidsModelSelection_actions()
 
-  % createDummyData();
-
   % GIVEN
   opt = setOptions('vislocalizer');
   opt = rmfield(opt, 'taskName');

tests/tests_workflows/stats/test_bidsResults.m

@@ -10,8 +10,6 @@
 
 function test_bidsResults_filter_by_nodeName()
 
-  % createDummyData();
-
   %% GIVEN
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
 
@@ -46,8 +44,6 @@ function test_bidsResults_filter_by_nodeName_empty()
 
 function test_bidsResults_too_many_backgrounds()
 
-  % createDummyData();
-
   %% GIVEN
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
 
@@ -77,8 +73,6 @@ function test_bidsResults_too_many_backgrounds()
 
 function test_bidsResults_background_for_subject()
 
-  % createDummyData();
-
   %% GIVEN
   opt = setOptions('vislocalizer', {'01', 'ctrl01', 'blind01'}, 'pipelineType', 'stats');
 
@@ -114,8 +108,6 @@ function test_bidsResults_background_for_subject()
 
 function test_bidsResults_no_background_for_montage()
 
-  % createDummyData();
-
   %% GIVEN
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
 
@@ -148,8 +140,6 @@ function test_bidsResults_dataset_lvl()
   % TODO requires updating dummy dataset
   return
 
-  % createDummyData();
-
   %% GIVEN
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
 
@@ -168,8 +158,6 @@ function test_bidsResults_dataset_lvl()
 
 function test_bidsResults_subject_lvl_regex()
 
-  % createDummyData();
-
   %% GIVEN
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
 
@@ -208,8 +196,6 @@ function test_bidsResults_error_missing_node()
 
 function test_bidsResults_subject_lvl()
 
-  % createDummyData();
-
   %% GIVEN
   opt = setOptions('vislocalizer', '', 'pipelineType', 'stats');
 

tests/tests_workflows/test_bidsChangeSuffix.m

@@ -10,8 +10,6 @@
 
 function test_bidsChangeSuffix_basic()
 
-  % createDummyData();
-
   dataset = 'ds001';
 
   dataDir = getBidsExample('ds001');

tests/tests_workflows/test_bidsRename.m

@@ -14,8 +14,6 @@ function test_bidsRename_basic()
   % - SpatialReference probably not needed for space individual if anat modality
   % - transfer of Skullstripped true, if sources has it?
 
-  % createDummyData();
-
   opt = setOptions('MoAE-preproc');
 
   % move test data into temp directory to test renaming