refactor

Author: Remi-Gau

miss_hit.cfg

@@ -17,5 +17,5 @@ copyright_entity: "spm_2_bids developers"
 # metric for code quality
 metric "cnest": limit 5
 metric "file_length": limit 500
-metric "cyc": limit 20
+metric "cyc": limit 16
 metric "parameters": limit 6

src/utils/identify_sources.m

@@ -1,11 +1,11 @@
-function sources = identify_sources(derivatives, map, verbose)
+function sources = identify_sources(varargin)
     %
     % finds the most likely files in the detrivatives that was used to create
     % this file
     %
     % USAGE::
     %
-    %   sources = identify_sources(derivatives, verbose)
+    %   sources = identify_sources(derivatives, map, verbose)
     %
     % :param file: SPM preprocessed filename (can be fullpath);
     %              for example ``wmsub-01_ses-01_T1w.nii``
@@ -25,6 +25,9 @@
     % functional to anatomical coregistration
     % anatomical to functional coregistration
 
+    default_map = Mapping();
+    default_map = default_map.default();
+
     sources = '';
 
     prefix_based = true;
@@ -52,17 +55,20 @@
                         'PDmap', ...
                         'UNIT1'};
 
-    if nargin < 1 || isempty(derivatives)
-        return
-    end
+    args = inputParser;
 
-    if nargin < 2 || isempty(map)
-        map = Mapping();
-        map = map.default();
-    end
+    addOptional(args, 'derivatives', pwd, @ischar);
+    addOptional(args, 'map', default_map);
+    addOptional(args, 'verbose', true, @islogical);
 
-    if nargin < 3
-        verbose = true;
+    parse(args, varargin{:});
+
+    derivatives = args.Results.derivatives;
+    map = args.Results.map;
+    verbose = args.Results.verbose;
+
+    if isempty(derivatives)
+        return
     end
 
     if endsWith(derivatives, '_seg8.mat')