🆕 Nicely catch and print parsing errors

Author: kris-jusiak

CMakeLists.txt

@@ -76,6 +76,7 @@ test(test/GMake SCENARIO=)
 test(test/GMock SCENARIO=)
 test(test/GSteps SCENARIO=)
 test(test/Features/Calc/Steps/CalcSteps SCENARIO=${CMAKE_CURRENT_SOURCE_DIR}/test/Features/Calc/addition.feature:${CMAKE_CURRENT_SOURCE_DIR}/test/Features/Calc/division.feature)
+#test(test/Features/Error/Steps/ErrorSteps SCENARIO=${CMAKE_CURRENT_SOURCE_DIR}/test/Features/Calc/addition.feature:${CMAKE_CURRENT_SOURCE_DIR}/test/Features/Error/error.feature)
 test(test/Features/Table/Steps/TableSteps SCENARIO=${CMAKE_CURRENT_SOURCE_DIR}/test/Features/Table/table.feature)
 test(test/Features/Tags/Steps/TagsSteps SCENARIO=${CMAKE_CURRENT_SOURCE_DIR}/test/Features/Tags/tags.feature)
 test(test/GTest SCENARIO=)

include/GUnit/GSteps.h

@@ -17,6 +17,7 @@
 #include <unordered_map>
 #include <utility>
 #include <vector>
+#include <cstdlib>
 #include "GUnit/Detail/FileUtils.h"
 #include "GUnit/Detail/Preprocessor.h"
 #include "GUnit/Detail/RegexUtils.h"
@@ -168,7 +169,8 @@ class Steps {
         steps.Init(pickles, file);
         static_cast<TCRTP&>(steps).Run();
         if (steps.current_step_ != steps.pickle_steps_.size()) {
-          throw StepIsNotImplemented{"STEP \"" + steps.not_found_ + "\" not implemented!"};
+          throw StepIsNotImplemented{"STEP \"" + steps.not_found_ +
+                                     "\" not implemented!"};
         }
         std::cout << '\n';
       }
@@ -365,30 +367,40 @@ class Steps {
   }
 
   void ParseAndRegister(const std::string& name, const std::string& feature) {
-    const auto content = read_file(feature);
-    gherkin::parser parser{L"en"};
-    gherkin::compiler compiler{feature};
-    const auto gherkin_document = parser.parse(content);
-    const auto pickles = compiler.compile(gherkin_document);
-    const auto ast = nlohmann::json::parse(compiler.ast(gherkin_document));
-
-    for (const auto& pickle : pickles) {
-      const std::string feature_name = ast["document"]["feature"]["name"];
-      const auto pickle_json = nlohmann::json::parse(pickle)["pickle"];
-      const std::string scenario_name = pickle_json["name"];
-      const auto tags = detail::make_tags(pickle_json["tags"]);
-      const auto disabled = tags.first ? "DISABLED_" : "";
-      const auto full_name = feature_name + "." + scenario_name;
-
-      if (PatternMatchesString(name.c_str(), full_name.c_str())) {
-        info_.feature = feature_name;
-
-        detail::MakeAndRegisterTestInfo(
-            new TestFactory{*this, pickle, feature},
-            disabled + feature_name + tags.second, scenario_name, __FILE__,
-            __LINE__,
-            detail::type<decltype(internal::MakeAndRegisterTestInfo)>{});
+    try {
+      const auto content = read_file(feature);
+      gherkin::parser parser{L"en"};
+      gherkin::compiler compiler{feature};
+      const auto gherkin_document = parser.parse(content);
+      const auto pickles = compiler.compile(gherkin_document);
+      const auto ast = nlohmann::json::parse(compiler.ast(gherkin_document));
+
+      for (const auto& pickle : pickles) {
+        const std::string feature_name = ast["document"]["feature"]["name"];
+        const auto pickle_json = nlohmann::json::parse(pickle)["pickle"];
+        const std::string scenario_name = pickle_json["name"];
+        const auto tags = detail::make_tags(pickle_json["tags"]);
+        const auto disabled = tags.first ? "DISABLED_" : "";
+        const auto full_name = feature_name + "." + scenario_name;
+
+        if (PatternMatchesString(name.c_str(), full_name.c_str())) {
+          info_.feature = feature_name;
+
+          detail::MakeAndRegisterTestInfo(
+              new TestFactory{*this, pickle, feature},
+              disabled + feature_name + tags.second, scenario_name, __FILE__,
+              __LINE__,
+              detail::type<decltype(internal::MakeAndRegisterTestInfo)>{});
+        }
       }
+    } catch (const gherkin::v1::parsing_error& err) {
+      const auto err_json = nlohmann::json::parse(err.what());
+      const auto line = err_json["source"]["start"]["line"];
+      const auto column = err_json["source"]["start"]["column"];
+      const std::string error = err_json["data"];
+
+      std::cerr << feature << ":" << line << ":" << column << ": error: " << error << std::endl;
+      std::exit(-1);
     }
   }
 

test/Features/Error/Steps/ErrorSteps.cpp

@@ -0,0 +1,10 @@
+//
+// Copyright (c) 2016-2017 Kris Jusiak (kris at jusiak dot net)
+//
+// Distributed under the Boost Software License, Version 1.0.
+// (See accompanying file LICENSE_1_0.txt or copy at
+// http://www.boost.org/LICENSE_1_0.txt)
+//
+#include "GUnit/GSteps.h"
+
+GSTEPS("Error*") { }

test/Features/Error/error.feature

@@ -0,0 +1,5 @@
+feature_parsing_error: Error
+
+  Scenario: Parsing error
+    Given I have a parsing error
+     Then An exception should be thrown