Addition format() testing #98
Conversation
|
An automated preview of the documentation is available at https://98.beast2.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-11-20 15:31:03 UTC |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
+ Coverage 53.19% 54.19% +0.99%
===========================================
Files 38 38
Lines 1690 1718 +28
===========================================
+ Hits 899 931 +32
+ Misses 791 787 -4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
GCOVR code coverage report https://98.beast2.prtest3.cppalliance.org/gcovr/index.html Build time: 2025-12-01 17:23:01 UTC |
|
if there is already full coverage then we can close this? |
include/boost/beast2/format.hpp
Outdated
| p0 = p; | ||
| return seg; | ||
| } | ||
| throw std::runtime_error("invalid format string, unmatched }"); |
There was a problem hiding this comment.
This seems kind of harsh... throwing? Anyway if we are going to throw we need to use the helpers in detail/except.hpp.
There was a problem hiding this comment.
Throwing is consistent with the behaviour of both fmtlib and std::format. Code that works with this implementation therefore has a clear migration path in the future.
Will change to use the helpers.
|
lets make sure we squash this down and have correct grammar in the commit message please |
3 participants
No description provided.