Merge pull request boostorg#291 from boostorg/sign

mborland · web-flow · commit 02583a162f7c · 2026-03-02T10:20:56.000-05:00
Fix sign conversion when Integer is a signed type
diff --git a/include/boost/charconv/detail/from_chars_integer_impl.hpp b/include/boost/charconv/detail/from_chars_integer_impl.hpp
@@ -155,8 +155,8 @@ BOOST_CXX14_CONSTEXPR from_chars_result from_chars_integer_impl(const char* firs
         else
         #endif
         {
-            overflow_value = (std::numeric_limits<Integer>::max)();
-            max_digit = (std::numeric_limits<Integer>::max)();
+            overflow_value = static_cast<Unsigned_Integer>((std::numeric_limits<Integer>::max)());
+            max_digit = static_cast<Unsigned_Integer>((std::numeric_limits<Integer>::max)());
         }
 
         if (is_negative)

Original file line number	Diff line number	Diff line change
`@@ -155,8 +155,8 @@ BOOST_CXX14_CONSTEXPR from_chars_result from_chars_integer_impl(const char* firs`
`155`	`155`	`else`
`156`	`156`	`#endif`
`157`	`157`	`{`
`158`		`- overflow_value = (std::numeric_limits<Integer>::max)();`
`159`		`- max_digit = (std::numeric_limits<Integer>::max)();`
	`158`	`+ overflow_value = static_cast<Unsigned_Integer>((std::numeric_limits<Integer>::max)());`
	`159`	`+ max_digit = static_cast<Unsigned_Integer>((std::numeric_limits<Integer>::max)());`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`if (is_negative)`