Move warning suppression

Author: mborland

examples/format.cpp

@@ -2,12 +2,6 @@
 // Distributed under the Boost Software License, Version 1.0.
 // https://www.boost.org/LICENSE_1_0.txt
 
-// MSVC 14.3 has a conversion error in <algorithm> so we need to try and supress that everywhere
-#ifdef _MSC_VER
-#  pragma warning(push)
-#  pragma warning(disable : 4244)
-#endif
-
 #include <boost/decimal.hpp>
 #include <iostream>
 

include/boost/decimal/format.hpp

@@ -143,9 +143,18 @@ struct formatter<T>
 
         if (is_upper)
         {
+            #ifdef _MSC_VER
+            #  pragma warning(push)
+            #  pragma warning(disable : 4244)
+            #endif
+
             std::transform(s.begin(), s.end(), s.begin(),
                            [](unsigned char c)
                            { return std::toupper(c); });
+
+            #ifdef _MSC_VER
+            #  pragma warning(pop)
+            #endif
         }
 
         if (s.size() < static_cast<std::size_t>(padding_digits))

test/test_format.cpp

@@ -2,12 +2,6 @@
 // Distributed under the Boost Software License, Version 1.0.
 // https://www.boost.org/LICENSE_1_0.txt
 
-// MSVC 14.3 has a conversion error in <algorithm> so we need to try and supress that everywhere
-#ifdef _MSC_VER
-#  pragma warning(push)
-#  pragma warning(disable : 4244)
-#endif
-
 #include <boost/decimal.hpp>
 #include <boost/core/lightweight_test.hpp>
 #include <limits>