Tighten some tolreances and syntax

ckormanyos · ckormanyos · commit 49a5605350be · 2024-05-12T15:37:33.000+02:00
diff --git a/include/boost/decimal/detail/cmath/atan.hpp b/include/boost/decimal/detail/cmath/atan.hpp
@@ -51,7 +51,8 @@ constexpr auto atan_impl(T x) noexcept
 
         if (x <= T { 48 })
         {
-            const bool is_smallish { x <= T { 3 } };
+            // Define small-ish argiments to be less than 39/16.
+            const bool is_smallish { x <= T { 24375, -4 } };
 
             // The portion of the algorithm for arc-tangent regarding scaling large-valued
             // argument is based on Chapter 11, page 194 of Cody and Waite, "Software Manual
diff --git a/include/boost/decimal/detail/cmath/impl/atan_impl.hpp b/include/boost/decimal/detail/cmath/impl/atan_impl.hpp
@@ -125,7 +125,7 @@ constexpr auto atan_series<decimal128>(decimal128 x) noexcept
             + x2 * (decimal128 { UINT64_C(5134145876036100) }
             + x2 * (decimal128 { UINT64_C(463911017673180) }
             + x2 * (decimal128 { UINT64_C(16016872057515) }
-            +       decimal128 { UINT64_C(90194313216) } * x2))))))))
+            + x2 *  decimal128 { UINT64_C(90194313216) }))))))))
         };
 
     const decimal128
@@ -140,7 +140,7 @@ constexpr auto atan_series<decimal128>(decimal128 x) noexcept
             + x2 * (decimal128 { UINT64_C(10819658401051500) }
             + x2 * (decimal128 { UINT64_C(1298359008126180) }
             + x2 * (decimal128 { UINT64_C(70562989572075) }
-            +       decimal128 { UINT64_C(1120047453525) } * x2))))))))
+            + x2 *  decimal128 { UINT64_C(1120047453525) }))))))))
         };
 
     return (x * top) / bot;
diff --git a/test/test_atan.cpp b/test/test_atan.cpp
@@ -380,7 +380,7 @@ int main()
     spot_test(0.181179F);
 
     {
-        const auto result_pos128_is_ok = local::test_atan_128(800'000);
+        const auto result_pos128_is_ok = local::test_atan_128(600'000);
 
         BOOST_TEST(result_pos128_is_ok);
     }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ constexpr auto atan_impl(T x) noexcept`
`51`	`51`
`52`	`52`	`if (x <= T { 48 })`
`53`	`53`	`{`
`54`		`- const bool is_smallish { x <= T { 3 } };`
	`54`	`+ // Define small-ish argiments to be less than 39/16.`
	`55`	`+ const bool is_smallish { x <= T { 24375, -4 } };`
`55`	`56`
`56`	`57`	`// The portion of the algorithm for arc-tangent regarding scaling large-valued`
`57`	`58`	`// argument is based on Chapter 11, page 194 of Cody and Waite, "Software Manual`
Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,7 @@ int main()`
`380`	`380`	`spot_test(0.181179F);`
`381`	`381`
`382`	`382`	`{`
`383`		`- const auto result_pos128_is_ok = local::test_atan_128(800'000);`
	`383`	`+ const auto result_pos128_is_ok = local::test_atan_128(600'000);`
`384`	`384`
`385`	`385`	`BOOST_TEST(result_pos128_is_ok);`
`386`	`386`	`}`