Remove branch from return condition

mborland · mborland · commit 4f829443e84b · 2025-11-20T14:38:33.000+01:00
diff --git a/include/boost/decimal/detail/add_impl.hpp b/include/boost/decimal/detail/add_impl.hpp
@@ -82,6 +82,8 @@ constexpr auto add_impl(const T& lhs, const T& rhs) noexcept -> ReturnType
                         big_lhs += 9U;
                         --lhs_exp;
                     }
+
+                    return ReturnType{big_lhs, lhs_exp, lhs.isneg()};
                 }
                 else
                 {
@@ -93,11 +95,9 @@ constexpr auto add_impl(const T& lhs, const T& rhs) noexcept -> ReturnType
                         big_rhs += 9U;
                         --rhs_exp;
                     }
-                }
 
-                return use_lhs ?
-                    ReturnType{big_lhs, lhs_exp, lhs.isneg()} :
-                    ReturnType{big_rhs, rhs_exp, rhs.isneg()};
+                    return ReturnType{big_rhs, rhs_exp, rhs.isneg()};
+                }
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,8 @@ constexpr auto add_impl(const T& lhs, const T& rhs) noexcept -> ReturnType`
`82`	`82`	`big_lhs += 9U;`
`83`	`83`	`--lhs_exp;`
`84`	`84`	`}`
	`85`	`+`
	`86`	`+ return ReturnType{big_lhs, lhs_exp, lhs.isneg()};`
`85`	`87`	`}`
`86`	`88`	`else`
`87`	`89`	`{`
`@@ -93,11 +95,9 @@ constexpr auto add_impl(const T& lhs, const T& rhs) noexcept -> ReturnType`
`93`	`95`	`big_rhs += 9U;`
`94`	`96`	`--rhs_exp;`
`95`	`97`	`}`
`96`		`- }`
`97`	`98`
`98`		`- return use_lhs ?`
`99`		`- ReturnType{big_lhs, lhs_exp, lhs.isneg()} :`
`100`		`- ReturnType{big_rhs, rhs_exp, rhs.isneg()};`
	`99`	`+ return ReturnType{big_rhs, rhs_exp, rhs.isneg()};`
	`100`	`+ }`
`101`	`101`	`}`
`102`	`102`	`else`
`103`	`103`	`{`