Merge pull request #540 from cppalliance/restore_promote

Restore mistakenly removed promotions

Author: mborland

include/boost/decimal/detail/cmath/log.hpp

@@ -21,8 +21,10 @@
 namespace boost {
 namespace decimal {
 
-BOOST_DECIMAL_EXPORT template <typename T>
-constexpr auto log(T x) noexcept
+namespace detail {
+
+template <typename T>
+constexpr auto log_impl(T x) noexcept
     BOOST_DECIMAL_REQUIRES(detail::is_decimal_floating_point_v, T)
 {
     constexpr T zero { 0, 0 };
@@ -93,6 +95,29 @@ constexpr auto log(T x) noexcept
     return result;
 }
 
+} //namespace detail
+
+BOOST_DECIMAL_EXPORT template <typename T>
+constexpr auto log(T x) noexcept
+    BOOST_DECIMAL_REQUIRES(detail::is_decimal_floating_point_v, T)
+{
+    #if BOOST_DECIMAL_DEC_EVAL_METHOD == 0
+
+    using evaluation_type = T;
+
+    #elif BOOST_DECIMAL_DEC_EVAL_METHOD == 1
+
+    using evaluation_type = detail::promote_args_t<T, decimal64>;
+
+    #else // BOOST_DECIMAL_DEC_EVAL_METHOD == 2
+
+    using evaluation_type = detail::promote_args_t<T, decimal128>;
+
+    #endif
+
+    return static_cast<T>(detail::log_impl(static_cast<evaluation_type>(x)));
+}
+
 } // namespace decimal
 } // namespace boost
 

include/boost/decimal/detail/cmath/log10.hpp

@@ -34,6 +34,9 @@ constexpr auto log10_impl(T x) noexcept
     // TODO(ckormanyos) Put in a basic check for pure powers of 10, resulting
     // in an exact result.
 
+    // Starting point: See implementation of log() and adapt to the following series.
+    // Series[Log[10] Log[10, (1 + (z/2))/(1 - (z/2))], {z, 0, 17}]
+
     return log(x) / numbers::ln10_v<T>;
 }
 

include/boost/decimal/detail/cmath/log1p.hpp

@@ -21,8 +21,10 @@
 namespace boost {
 namespace decimal {
 
-BOOST_DECIMAL_EXPORT template <typename T>
-constexpr auto log1p(T x) noexcept
+namespace detail {
+
+template <typename T>
+constexpr auto log1p_impl(T x) noexcept
     BOOST_DECIMAL_REQUIRES(detail::is_decimal_floating_point_v, T)
 {
     constexpr T one { 1, 0 };
@@ -64,6 +66,29 @@ constexpr auto log1p(T x) noexcept
     return result;
 }
 
+} // namespace detail
+
+BOOST_DECIMAL_EXPORT template <typename T>
+constexpr auto log1p(T x) noexcept
+    BOOST_DECIMAL_REQUIRES(detail::is_decimal_floating_point_v, T)
+{
+    #if BOOST_DECIMAL_DEC_EVAL_METHOD == 0
+
+    using evaluation_type = T;
+
+    #elif BOOST_DECIMAL_DEC_EVAL_METHOD == 1
+
+    using evaluation_type = detail::promote_args_t<T, decimal64>;
+
+    #else // BOOST_DECIMAL_DEC_EVAL_METHOD == 2
+
+    using evaluation_type = detail::promote_args_t<T, decimal128>;
+
+    #endif
+
+    return static_cast<T>(detail::log1p_impl(static_cast<evaluation_type>(x)));
+}
+
 } // namespace decimal
 } // namespace boost
 

include/boost/decimal/detail/cmath/sinh.hpp

@@ -21,8 +21,10 @@
 namespace boost {
 namespace decimal {
 
-BOOST_DECIMAL_EXPORT template <typename T>
-constexpr auto sinh(T x) noexcept
+namespace detail {
+
+template <typename T>
+constexpr auto sinh_impl(T x) noexcept
     BOOST_DECIMAL_REQUIRES(detail::is_decimal_floating_point_v, T)
 {
     const auto fpc = fpclassify(x);
@@ -78,6 +80,29 @@ constexpr auto sinh(T x) noexcept
     return result;
 }
 
+} // namespace detail
+
+BOOST_DECIMAL_EXPORT template <typename T>
+constexpr auto sinh(T x) noexcept
+    BOOST_DECIMAL_REQUIRES(detail::is_decimal_floating_point_v, T)
+{
+    #if BOOST_DECIMAL_DEC_EVAL_METHOD == 0
+
+    using evaluation_type = T;
+
+    #elif BOOST_DECIMAL_DEC_EVAL_METHOD == 1
+
+    using evaluation_type = detail::promote_args_t<T, decimal64>;
+
+    #else // BOOST_DECIMAL_DEC_EVAL_METHOD == 2
+
+    using evaluation_type = detail::promote_args_t<T, decimal128>;
+
+    #endif
+
+    return static_cast<T>(detail::sinh_impl(static_cast<evaluation_type>(x)));
+}
+
 } // namespace decimal
 } // namespace boost