Simplify log edge cases and update CodeCov

ckormanyos · ckormanyos · commit 6d5abe2c78b3 · 2024-05-10T09:28:40.000+02:00
diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
@@ -64,7 +64,7 @@ jobs:
           make gcov -f make_gcov_01_generic.gmk --jobs=8 MY_ALL_COV=0 MY_BOOST_ROOT=../../../boost-root MY_CC=${{ matrix.compiler }} MY_STD=${{ matrix.standard }}
           echo
       - name: upload-codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           files: ./test/cover/coverage.info
           token: ${{ secrets.CODECOV_TOKEN }}
diff --git a/include/boost/decimal/detail/cmath/log.hpp b/include/boost/decimal/detail/cmath/log.hpp
@@ -47,19 +47,8 @@ constexpr auto log_impl(T x) noexcept
     }
     else if (x < one)
     {
-        // Handle reflection, the [+/-] zero-pole, and non-pole, negative x.
-        if (x > zero)
-        {
-            result = -log(one / x);
-        }
-        else if ((x == zero) || (-x == zero))
-        {
-            result = -std::numeric_limits<T>::infinity();
-        }
-        else
-        {
-            result = std::numeric_limits<T>::quiet_NaN();
-        }
+        // Handle reflection.
+        result = -log(one / x);
     }
     else if(x > one)
     {
diff --git a/include/boost/decimal/detail/cmath/log10.hpp b/include/boost/decimal/detail/cmath/log10.hpp
@@ -71,19 +71,8 @@ constexpr auto log10_impl(T x) noexcept
         {
             if (x < one)
             {
-                // Handle reflection, the [+/-] zero-pole, and non-pole, negative x.
-                if (x > zero)
-                {
-                    result = -log10(one / x);
-                }
-                else if ((x == zero) || (-x == zero))
-                {
-                    result = -std::numeric_limits<T>::infinity();
-                }
-                else
-                {
-                    result = std::numeric_limits<T>::quiet_NaN();
-                }
+                // Handle reflection.
+                result = -log10(one / x);
             }
             else if(x > one)
             {

Original file line number	Diff line number	Diff line change
`@@ -47,19 +47,8 @@ constexpr auto log_impl(T x) noexcept`
`47`	`47`	`}`
`48`	`48`	`else if (x < one)`
`49`	`49`	`{`
`50`		`- // Handle reflection, the [+/-] zero-pole, and non-pole, negative x.`
`51`		`- if (x > zero)`
`52`		`- {`
`53`		`- result = -log(one / x);`
`54`		`- }`
`55`		`- else if ((x == zero) \|\| (-x == zero))`
`56`		`- {`
`57`		`- result = -std::numeric_limits<T>::infinity();`
`58`		`- }`
`59`		`- else`
`60`		`- {`
`61`		`- result = std::numeric_limits<T>::quiet_NaN();`
`62`		`- }`
	`50`	`+ // Handle reflection.`
	`51`	`+ result = -log(one / x);`
`63`	`52`	`}`
`64`	`53`	`else if(x > one)`
`65`	`54`	`{`
Original file line number	Diff line number	Diff line change
`@@ -71,19 +71,8 @@ constexpr auto log10_impl(T x) noexcept`
`71`	`71`	`{`
`72`	`72`	`if (x < one)`
`73`	`73`	`{`
`74`		`- // Handle reflection, the [+/-] zero-pole, and non-pole, negative x.`
`75`		`- if (x > zero)`
`76`		`- {`
`77`		`- result = -log10(one / x);`
`78`		`- }`
`79`		`- else if ((x == zero) \|\| (-x == zero))`
`80`		`- {`
`81`		`- result = -std::numeric_limits<T>::infinity();`
`82`		`- }`
`83`		`- else`
`84`		`- {`
`85`		`- result = std::numeric_limits<T>::quiet_NaN();`
`86`		`- }`
	`74`	`+ // Handle reflection.`
	`75`	`+ result = -log10(one / x);`
`87`	`76`	`}`
`88`	`77`	`else if(x > one)`
`89`	`78`	`{`