Deal with constexpr abs() all over

Author: ckormanyos

include/boost/decimal/charconv.hpp

@@ -318,7 +318,9 @@ BOOST_DECIMAL_CONSTEXPR auto to_chars_scientific_impl(char* first, char* last, c
 
     // Insert the exponent character
     *first++ = 'e';
-    const int abs_exp {std::abs(exp)};
+
+    const int abs_exp { (exp < 0) ? -exp : exp };
+
     if (exp < 0)
     {
         *first++ = '-';
@@ -383,7 +385,9 @@ BOOST_DECIMAL_CONSTEXPR auto to_chars_fixed_impl(char* first, char* last, const
 
     if (integer_digits < 0)
     {
-        num_leading_zeros = std::abs(integer_digits);
+        const int abs_integer_digits { (integer_digits < 0) ? -integer_digits : integer_digits };
+
+        num_leading_zeros = abs_integer_digits;
         integer_digits = 0;
         append_leading_zeros = true;
     }
@@ -683,12 +687,16 @@ BOOST_DECIMAL_CONSTEXPR auto to_chars_hex_impl(char* first, char* last, const Ta
         *first++ = '+';
     }
 
-    if (std::abs(exp) < 10)
+    const int abs_exp { (exp < 0) ? -exp : exp };
+
+    if (abs_exp < 10)
     {
         *first++ = '0';
     }
 
-    return to_chars_integer_impl<std::uint32_t, std::uint32_t>(first, last, static_cast<std::uint32_t>(std::abs(exp)), 10);
+    const int abs_exp { (exp < 0) ? -exp : exp };
+
+    return to_chars_integer_impl<std::uint32_t, std::uint32_t>(first, last, static_cast<std::uint32_t>(abs_exp), 10);
 }
 
 template <BOOST_DECIMAL_DECIMAL_FLOATING_TYPE TargetDecimalType>

include/boost/decimal/detail/cmath/pow.hpp

@@ -245,12 +245,10 @@ constexpr auto pow(T x, T a) noexcept
             }
             else if (fpc_a == FP_INFINITE)
             {
-                using std::abs;
-
                 result =
                     (
-                          (abs(x) < one) ? (signbit(a) ? std::numeric_limits<T>::infinity() : zero)
-                        : (abs(x) > one) ? (signbit(a) ? zero : std::numeric_limits<T>::infinity())
+                          (fabs(x) < one) ? (signbit(a) ? std::numeric_limits<T>::infinity() : zero)
+                        : (fabs(x) > one) ? (signbit(a) ? zero : std::numeric_limits<T>::infinity())
                         : one
                     );
             }

include/boost/decimal/detail/cmath/rint.hpp

@@ -34,7 +34,10 @@ constexpr auto rint_impl(T1& sig, T2 exp, bool sign)
     using RoundType = std::conditional_t<std::is_same<T1, std::uint32_t>::value, decimal32,
                       std::conditional_t<std::is_same<T1, std::uint64_t>::value, decimal64, decimal128>>;
 
-    sig /= detail::pow10(static_cast<T1>(std::abs(exp) - 1));
+    const T2 abs_exp { (exp < T2(0)) ? -exp : exp };
+
+    sig /= detail::pow10(static_cast<T1>(abs_exp - 1));
+
     detail::fenv_round<RoundType>(sig, sign);
 }