Fix comp of zero for decimal32

mborland · mborland · commit 9aa0d2db18d6 · 2025-01-20T10:48:35.000-05:00
diff --git a/include/boost/decimal/detail/comparison.hpp b/include/boost/decimal/detail/comparison.hpp
@@ -57,8 +57,12 @@ BOOST_DECIMAL_FORCE_INLINE constexpr auto equality_impl(DecimalType lhs, Decimal
 
     const auto delta_exp {lhs_exp - rhs_exp};
 
-    if (delta_exp > detail::precision_v<DecimalType> || delta_exp < -detail::precision_v<DecimalType> ||
-        ((lhs_sig == static_cast<comp_type>(0)) ^ (rhs_sig == static_cast<comp_type>(0))))
+    if (lhs_sig == 0 && rhs_sig == 0)
+    {
+        // The difference in exponent is irrelevant here
+        return true;
+    }
+    if (delta_exp > detail::precision_v<DecimalType> || delta_exp < -detail::precision_v<DecimalType>)
     {
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,12 @@ BOOST_DECIMAL_FORCE_INLINE constexpr auto equality_impl(DecimalType lhs, Decimal`
`57`	`57`
`58`	`58`	`const auto delta_exp {lhs_exp - rhs_exp};`
`59`	`59`
`60`		`- if (delta_exp > detail::precision_v<DecimalType> \|\| delta_exp < -detail::precision_v<DecimalType> \|\|`
`61`		`- ((lhs_sig == static_cast<comp_type>(0)) ^ (rhs_sig == static_cast<comp_type>(0))))`
	`60`	`+ if (lhs_sig == 0 && rhs_sig == 0)`
	`61`	`+ {`
	`62`	`+ // The difference in exponent is irrelevant here`
	`63`	`+ return true;`
	`64`	`+ }`
	`65`	`+ if (delta_exp > detail::precision_v<DecimalType> \|\| delta_exp < -detail::precision_v<DecimalType>)`
`62`	`66`	`{`
`63`	`67`	`return false;`
`64`	`68`	`}`