Skip to content

Remove old testing facilities from public headers #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mborland merged 4 commits into from
Nov 6, 2025
Merged

Remove old testing facilities from public headers #1223

mborland merged 4 commits into from
Nov 6, 2025

Conversation

@mborland
Copy link
Member

@mborland mborland commented Nov 6, 2025

Closes: #1192

@mborland mborland added this to the v6.0.0 milestone Nov 6, 2025
@mborland mborland self-assigned this Nov 6, 2025
@mborland mborland added the Boost Review Collected Comments from Boost Review Period label Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.1%. Comparing base (0bc45a2) to head (5ffac74).
⚠️ Report is 40 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1223   +/-   ##
=======================================
  Coverage     99.1%   99.1%           
=======================================
  Files          260     260           
  Lines        17158   17158           
  Branches      1935    1935           
=======================================
  Hits         16995   16995           
  Misses         163     163
Files with missing lines Coverage Δ
include/boost/decimal/decimal128_t.hpp 98.2% <ø> (ø)
include/boost/decimal/decimal32_t.hpp 96.6% <ø> (ø)
test/compare_dec128_and_fast.cpp 97.6% <ø> (ø)
test/random_decimal128_comp.cpp 100.0% <ø> (ø)
test/random_decimal128_fast_comp.cpp 100.0% <ø> (ø)
test/random_decimal128_fast_math.cpp 100.0% <ø> (ø)
test/random_decimal128_math.cpp 100.0% <ø> (ø)
test/random_decimal32_comp.cpp 100.0% <ø> (ø)
test/random_decimal32_fast_comp.cpp 100.0% <ø> (ø)
test/random_decimal32_fast_math.cpp 100.0% <ø> (ø)
... and 53 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bc45a2...5ffac74. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckormanyos
Copy link
Collaborator

ckormanyos commented Nov 6, 2025

It's good to get rid of that clunky compiler definition. Thanks yet again, Matt

@mborland mborland merged commit ba749cf into develop Nov 6, 2025
77 checks passed
@mborland mborland deleted the testing_faciliites branch November 6, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mborland mborland

Labels

Boost Review Collected Comments from Boost Review Period

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

Review 2: Testing code in public headers?

3 participants

@mborland @ckormanyos