body_read_stream implementation - WORK IN PROGRESS #57
+580
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinniefalco
reviewed
Oct 16, 2025
|
|
||
| #include <boost/http_io/detail/config.hpp> | ||
| #include <boost/http_proto/request_parser.hpp> | ||
| #include <boost/http_proto/response_parser.hpp> |
There was a problem hiding this comment.
you should be able to get away with just parser.hpp instead of these other two
vinniefalco
reviewed
Oct 16, 2025
| #include <boost/http_proto/response_parser.hpp> | ||
| #include <boost/asio/async_result.hpp> | ||
| #include <boost/system/error_code.hpp> | ||
| #include <boost/system/result.hpp> |
There was a problem hiding this comment.
I don't think result.hpp is going to help?
vinniefalco
reviewed
Oct 16, 2025
|
|
||
| template<class UnderlyingAsyncReadStream> | ||
| body_read_stream<UnderlyingAsyncReadStream>::body_read_stream( | ||
| const rts::context& rts_ctx |
There was a problem hiding this comment.
I don't think the context is needed
MungoG
commented
Oct 16, 2025
| namespace http_io { | ||
|
|
||
| template<class UnderlyingAsyncReadStream> | ||
| class body_read_stream { |
There was a problem hiding this comment.
Note to self: add get_executor()
vinniefalco
reviewed
Oct 17, 2025
|
|
||
| namespace detail { | ||
|
|
||
| template <class MutableBufferSequence, class UnderlyingAsyncReadStream> |
There was a problem hiding this comment.
Maybe just Stream would suffice instead of UnderlyingAsyncReadStreamToUseForTheNextLayer?
|
An automated preview of the documentation is available at https://57.http-io.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-10-20 18:03:41 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for the body_read_stream part of #55