feat: javascript helpers extension

fix #881

Author: alandefreitas

src/lib/Support/JavaScript.cpp

@@ -2,17 +2,15 @@
 // JerryScript-backed JavaScript bridge for MrDocs
 //
 
-#include <mrdocs/Support/JavaScript.hpp>
+#include <mrdocs/Dom.hpp>
 #include <mrdocs/Support/Handlebars.hpp>
-#include <mrdocs/Support/Report.hpp>
+#include <mrdocs/Support/JavaScript.hpp>
 #include <mrdocs/Support/Path.hpp>
-#include <mrdocs/Dom.hpp>
-
-#include <jerryscript.h>
-
-#include <cctype>
+#include <mrdocs/Support/Report.hpp>
 #include <algorithm>
+#include <cctype>
 #include <format>
+#include <jerryscript.h>
 #include <limits>
 #include <memory>
 #include <mutex>
@@ -35,7 +33,10 @@ static std::string toString(jerry_value_t v)
 {
     jerry_value_t str = jerry_value_to_string(v);
     if (jerry_value_is_exception(str))
+    {
+        jerry_value_free(str);
         return "<error>";
+    }
     jerry_size_t sz = jerry_string_size(str, JERRY_ENCODING_UTF8);
     std::string out(sz, '\0');
     jerry_string_to_buffer(str, JERRY_ENCODING_UTF8, (jerry_char_t*)out.data(), sz);
@@ -51,7 +52,10 @@ static Error makeError(jerry_value_t exc)
     }
     jerry_value_t msg_prop = jerry_object_get(exc, jerry_string_sz("message"));
     if (jerry_value_is_exception(msg_prop))
+    {
+        jerry_value_free(msg_prop);
         return Error("JavaScript error");
+    }
     std::string msg = toString(msg_prop);
     jerry_value_free(msg_prop);
     return Error(msg.empty() ? "JavaScript error" : msg);
@@ -369,7 +373,10 @@ Value Value::get(std::string_view name) const
     jerry_value_t v = jerry_object_get(obj, k);
     jerry_value_free(k);
     if (jerry_value_is_exception(v))
+    {
+        jerry_value_free(v);
         return {};
+    }
     return Value::fromJs(nullptr, to_handle(v), impl_);
 }
 
@@ -393,7 +400,11 @@ Expected<Value, Error> Value::callImpl(std::span<const dom::Value> args) const
     jerry_value_t ret = jerry_call(fn, jerry_undefined(), jsArgs.data(), jsArgs.size());
     for (auto& a : jsArgs) jerry_value_free(a);
     if (jerry_value_is_exception(ret))
-        return Unexpected(makeError(ret));
+    {
+        auto err = makeError(ret);
+        jerry_value_free(ret);
+        return Unexpected(err);
+    }
     return Value::fromJs(nullptr, to_handle(ret), impl_);
 }
 
@@ -459,7 +470,11 @@ Expected<Value, Error> Scope::eval(std::string_view script)
     std::scoped_lock<std::recursive_mutex> lk(impl_->mtx);
     jerry_value_t res = jerry_eval((const jerry_char_t*)script.data(), script.size(), JERRY_PARSE_NO_OPTS);
     if (jerry_value_is_exception(res))
-        return Unexpected(makeError(res));
+    {
+        auto err = makeError(res);
+        jerry_value_free(res);
+        return Unexpected(err);
+    }
     return Value::fromJs(nullptr, res, impl_);
 }
 
@@ -587,7 +602,11 @@ Expected<Value, Error> Scope::getGlobal(std::string_view name)
     jerry_value_free(realm);
     jerry_value_free(k);
     if (jerry_value_is_exception(v))
-        return Unexpected(makeError(v));
+    {
+        auto err = makeError(v);
+        jerry_value_free(v);
+        return Unexpected(err);
+    }
     return Value::fromJs(nullptr, v, impl_);
 }