ci(danger): correct file delta calculation in reports

Author: alandefreitas

util/danger/format.test.ts

@@ -48,4 +48,20 @@ describe("renderDangerReport", () => {
         expect(output).toContain("## ✨ Highlights");
         expect(output.trim().startsWith("> 🚧 Danger.js checks for MrDocs")).toBe(true);
     });
+
+    it("treats removed files as positive file deltas", () => {
+        const summary = summarizeScopes([
+            { filename: "src/lib/old.cpp", additions: 0, deletions: 5, status: "removed" },
+        ]);
+        const result: DangerResult = { warnings: [], summary };
+
+        const output = renderDangerReport(result);
+        const sourceRow = output.split("\n").find((line) => line.startsWith("| Source"));
+
+        expect(sourceRow).toBeDefined();
+        expect(sourceRow).not.toMatch(/-1/);
+        expect(sourceRow).toMatch(
+            /\|\s*Source\s*\|\s*\*\*5\*\*\s*\|\s*-\s*\|\s*5\s*\|\s*\*\*1\*\*\s*\|\s*-\s*\|\s*-\s*\|\s*-\s*\|\s*1\s*\|/,
+        );
+    });
 });

util/danger/format.ts

@@ -80,6 +80,10 @@ function renderWarnings(warnings: string[]): string {
     return ["## ⚠️ Warnings", blocks.join("\n\n")].join("\n");
 }
 
+function countFileChanges(status: ScopeTotals["status"]): number {
+    return status.added + status.modified + status.renamed + status.removed + status.other;
+}
+
 /**
  * Render a single table combining change summary and per-scope breakdown.
  */
@@ -100,14 +104,14 @@ function renderChangeTable(summary: ScopeReport): string {
 
     const scopeHasChange = (totals: ScopeTotals): boolean => {
         const churn = totals.additions + totals.deletions;
-        const fileDelta = totals.status.added + totals.status.modified + totals.status.renamed - totals.status.removed;
+        const fileDelta = countFileChanges(totals.status);
         return churn !== 0 || fileDelta !== 0;
     };
 
     const scopeRows = sortedScopes.filter((scope) => scopeHasChange(summary.totals[scope])).map((scope) => {
         const scoped: ScopeTotals = summary.totals[scope];
         const s = scoped.status;
-        const fileDelta = s.added + s.modified + s.renamed - s.removed;
+        const fileDelta = countFileChanges(s);
         const churn = scoped.additions + scoped.deletions;
         const fileDeltaBold = formatCount(fileDelta); // bold delta
         const label = labelForScope(scope);
@@ -127,7 +131,7 @@ function renderChangeTable(summary: ScopeReport): string {
     const total = summary.overall;
     const totalStatus = total.status;
     const totalChurn = total.additions + total.deletions;
-    const totalFileDelta = totalStatus.added + totalStatus.modified + totalStatus.renamed - totalStatus.removed;
+    const totalFileDelta = countFileChanges(totalStatus);
     const totalRow = [
         "**Total**",
         formatCount(totalChurn),