cached symbol lookup

#perf

Author: alandefreitas

include/mrdocs/Corpus.hpp

@@ -66,31 +66,41 @@ class MRDOCS_VISIBLE
 
     /** Return the begin iterator for the index of all symbols.
     */
-    MRDOCS_DECL
     virtual
     iterator
     begin() const noexcept = 0;
 
     /** Return the end iterator for the index.
     */
-    MRDOCS_DECL
     virtual
     iterator
     end() const noexcept = 0;
 
     /** Whether the corpus contains any symbols.
     */
-    MRDOCS_DECL
     bool
     empty() const noexcept;
 
     /** Return the Info with the matching ID, or nullptr.
     */
-    MRDOCS_DECL
     virtual
     Info const*
     find(SymbolID const& id) const noexcept = 0;
 
+    /** Return the Info for the matching string in a given context.
+    */
+    virtual
+    Info const*
+    lookup(SymbolID const& context, std::string_view name) const = 0;
+
+    /** Return the Info for the matching string in the global context.
+    */
+    Info const*
+    lookup(std::string_view name) const
+    {
+        return lookup(SymbolID::global, name);
+    }
+
     /** Return true if an Info with the specified symbol ID exists.
 
         This function uses the @ref find function to locate
@@ -127,7 +137,6 @@ class MRDOCS_VISIBLE
         @ref get with the symbol ID for the
         global namespace.
     */
-    MRDOCS_DECL
     NamespaceInfo const&
     globalNamespace() const noexcept;
 
@@ -327,11 +336,11 @@ class MRDOCS_VISIBLE
 
         @return A reference to the string `temp`.
      */
-    MRDOCS_DECL
+    virtual
     void
     qualifiedName(
         Info const& I,
-        std::string& temp) const;
+        std::string& temp) const = 0;
 
     std::string
     qualifiedName(Info const& I) const

src/lib/Lib/Corpus.cpp

@@ -49,59 +49,6 @@ globalNamespace() const noexcept
 //
 //------------------------------------------------
 
-// KRYSTIAN NOTE: temporary
-void
-Corpus::
-qualifiedName(
-    Info const& I,
-    std::string& temp) const
-{
-    temp.clear();
-    if(! I.id || I.id == SymbolID::global)
-    {
-        return;
-    }
-
-    MRDOCS_ASSERT(I.Parent);
-    for(auto const& pID : getParents(*this, I))
-    {
-        if (!pID || pID == SymbolID::global)
-        {
-            continue;
-        }
-        if (Info const* P = find(pID))
-        {
-            if (!P->Name.empty())
-            {
-                temp.append(P->Name);
-            }
-            else
-            {
-                fmt::format_to(
-                    std::back_inserter(temp),
-                    "<unnamed {}>",
-                    toString(P->Kind));
-            }
-        }
-        else
-        {
-            temp.append("<unnamed>");
-        }
-        temp.append("::");
-    }
-    if (I.Name.empty())
-    {
-        fmt::format_to(
-            std::back_inserter(temp),
-            "<unnamed {}>",
-            toString(I.Kind));
-    }
-    else
-    {
-        temp.append(I.Name);
-    }
-}
-
 std::vector<SymbolID>
 getParents(Corpus const& C, Info const& I)
 {