option name is extract-anonymous-namespaces

#refactor

Author: alandefreitas

docs/mrdocs.schema.json

@@ -7,16 +7,6 @@
       "title": "Path to the Addons directory",
       "type": "string"
     },
-    "anonymous-namespaces": {
-      "default": true,
-      "description": "Determine whether symbols in anonymous namespaces should be extracted. When set to `always`, symbols in anonymous namespaces are always extracted. When set to `dependency`, symbols in anonymous namespaces are extracted only if they are referenced by the source code. When set to `never`, symbols in anonymous namespaces are never extracted.",
-      "enum": [
-        true,
-        false
-      ],
-      "title": "Extraction policy for anonymous namespaces",
-      "type": "boolean"
-    },
     "auto-brief": {
       "default": true,
       "description": "When set to `true`, MrDocs uses the first line (until the first dot, question mark, or exclamation mark) of the comment as the brief of the symbol. When set to `false`, a explicit @brief command is required.",
@@ -101,6 +91,16 @@
       "title": "Extract all symbols",
       "type": "boolean"
     },
+    "extract-anonymous-namespaces": {
+      "default": true,
+      "description": "Determine whether symbols in anonymous namespaces should be extracted. When set to `always`, symbols in anonymous namespaces are always extracted. When set to `dependency`, symbols in anonymous namespaces are extracted only if they are referenced by the source code. When set to `never`, symbols in anonymous namespaces are never extracted.",
+      "enum": [
+        true,
+        false
+      ],
+      "title": "Extraction policy for anonymous namespaces",
+      "type": "boolean"
+    },
     "extract-private": {
       "default": false,
       "description": "Determine whether private class members should be extracted",

src/lib/AST/ASTVisitor.cpp

@@ -2705,34 +2705,23 @@ checkTypeFilters(Decl const* D, AccessSpecifier const access)
 {
     if (!config_->extractPrivate)
     {
-        // KRYSTIAN FIXME: this doesn't handle direct
-        // dependencies on inaccessible declarations
+        MRDOCS_CHECK_OR(access != AccessSpecifier::AS_private, false);
+    }
+    if (!config_->extractAnonymousNamespaces)
+    {
         MRDOCS_CHECK_OR(
-             access != AccessSpecifier::AS_private, false);
+            !isa<NamespaceDecl>(D) ||
+            !dyn_cast<NamespaceDecl>(D)->isAnonymousNamespace(),
+            false);
     }
 
     // Don't extract anonymous unions
     auto const* RD = dyn_cast<RecordDecl>(D);
     MRDOCS_CHECK_OR(!RD || !RD->isAnonymousStructOrUnion(), false);
 
     // Don't extract implicitly generated declarations
-    // (except for IndirectFieldDecls)
     MRDOCS_CHECK_OR(!D->isImplicit() || isa<IndirectFieldDecl>(D), false);
 
-    // Don't extract anonymous namespaces unless configured to do so
-    // and the current mode is normal
-    if (auto const* ND = dyn_cast<NamespaceDecl>(D);
-        ND &&
-        ND->isAnonymousNamespace() &&
-        config_->anonymousNamespaces)
-    {
-        // Otherwise, skip extraction if this isn't a dependency
-        // KRYSTIAN FIXME: is this correct? a namespace should not
-        // be extracted as a dependency (until namespace aliases and
-        // using directives are supported)
-        MRDOCS_CHECK_OR(mode_ == TraversalMode::Regular, false);
-    }
-
     return true;
 }
 

src/lib/Lib/ConfigOptions.json

@@ -200,7 +200,7 @@
         "default": false
       },
       {
-        "name": "anonymous-namespaces",
+        "name": "extract-anonymous-namespaces",
         "brief": "Extraction policy for anonymous namespaces",
         "details": "Determine whether symbols in anonymous namespaces should be extracted. When set to `always`, symbols in anonymous namespaces are always extracted. When set to `dependency`, symbols in anonymous namespaces are extracted only if they are referenced by the source code. When set to `never`, symbols in anonymous namespaces are never extracted.",
         "type": "bool",