Corpus qualified name returns void

#refactor

Author: alandefreitas

include/mrdocs/Corpus.hpp

@@ -197,18 +197,18 @@ class MRDOCS_VISIBLE
 
         @return A reference to the string `temp`.
      */
-    // KRYSTIAN NOTE: temporary
     MRDOCS_DECL
-    std::string&
-    getFullyQualifiedName(
-        const Info& I,
+    void
+    qualifiedName(
+        Info const& I,
         std::string& temp) const;
 
     std::string
-    getFullyQualifiedName(const Info& I) const
+    qualifiedName(const Info& I) const
     {
         std::string temp;
-        return getFullyQualifiedName(I, temp);
+        qualifiedName(I, temp);
+        return temp;
     }
 
 };

src/lib/Gen/xml/XMLWriter.cpp

@@ -161,24 +161,28 @@ writeIndex()
     tags_.open("symbols");
     if(options_.legible_names)
     {
-        LegibleNames names(corpus_, true);
+        LegibleNames const names(corpus_, true);
         for(auto& I : corpus_)
         {
+            corpus_.qualifiedName(I, temp);
             auto legible_name = names.getUnqualified(I.id);
             tags_.write("symbol", {}, {
                 { "legible", legible_name },
-                { "name", corpus_.getFullyQualifiedName(I, temp) },
+                { "name", temp },
                 { "tag", toString(I.Kind) },
                 { I.id } });
         }
     }
     else
     {
         for(auto& I : corpus_)
+        {
+            corpus_.qualifiedName(I, temp);
             tags_.write("symbol", {}, {
-                { "name", corpus_.getFullyQualifiedName(I, temp) },
+                { "name", temp },
                 { "tag", toString(I.Kind) },
                 { I.id } });
+        }
     }
     tags_.close("symbols");
 }

src/lib/Lib/Corpus.cpp

@@ -51,15 +51,17 @@ globalNamespace() const noexcept
 //------------------------------------------------
 
 // KRYSTIAN NOTE: temporary
-std::string&
+void
 Corpus::
-getFullyQualifiedName(
+qualifiedName(
     const Info& I,
     std::string& temp) const
 {
     temp.clear();
     if(! I.id || I.id == SymbolID::global)
-        return temp;
+    {
+        return;
+    }
 
     MRDOCS_ASSERT(I.Parent);
     for(auto const& pID : getParents(*this, I))
@@ -99,22 +101,29 @@ getFullyQualifiedName(
     {
         temp.append(I.Name);
     }
-    return temp;
 }
 
 std::vector<SymbolID>
 getParents(Corpus const& C, const Info& I)
 {
-    // AFREITAS: This function could eventually
-    // return a view.
     std::vector<SymbolID> parents;
+    std::size_t n = 0;
     auto curParent = I.Parent;
     while (curParent)
     {
-        parents.push_back(curParent);
+        ++n;
+        MRDOCS_ASSERT(C.find(curParent));
+        curParent = C.get(curParent).Parent;
+    }
+    parents.reserve(n);
+    parents.resize(n);
+    curParent = I.Parent;
+    while (curParent)
+    {
+        parents[--n] = curParent;
+        MRDOCS_ASSERT(C.find(curParent));
         curParent = C.get(curParent).Parent;
     }
-    std::ranges::reverse(parents);
     return parents;
 }
 

src/lib/Lib/TagfileWriter.cpp

@@ -134,7 +134,7 @@ writeNamespace(
             { "kind", "namespace" }
         });
 
-        tags_.write("name", corpus_->getFullyQualifiedName(I));
+        tags_.write("name", corpus_->qualifiedName(I));
         tags_.write("filename", generateFilename(I));
 
         // Write the class-like members of this namespace
@@ -144,7 +144,7 @@ writeNamespace(
             {
                 tags_.write(
                     "class",
-                    corpus_->getFullyQualifiedName(J),
+                    corpus_->qualifiedName(J),
                     {{"kind", "class"}});
             }
         });
@@ -178,7 +178,7 @@ writeClassLike(
     tags_.open("compound", {
         { "kind", "class" }
     });
-    tags_.write("name", corpus_->getFullyQualifiedName(I));
+    tags_.write("name", corpus_->qualifiedName(I));
     tags_.write("filename", generateFilename(I));
     if constexpr (T::isRecord())
     {