build: LLVM runtimes come from presets

Author: alandefreitas

.github/workflows/ci.yml

@@ -262,7 +262,6 @@ jobs:
           preset: ${{ matrix.llvm-build-preset }}
           build-type: ${{ matrix.build-type }}
           extra-args: |
-            ${{ runner.os == 'Windows' && '-DLLVM_ENABLE_RUNTIMES=libcxx' || '-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi;libunwind' }}
             -DLLVM_USE_SANITIZER=${{ matrix.llvm-sanitizer-config }}
           cc: ${{ steps.setup-cpp.outputs.cc }}
           cxx: ${{ steps.setup-cpp.outputs.cxx }}

bootstrap.py

@@ -690,10 +690,6 @@ def install_llvm(self):
         self.prompt_dependency_path_option("llvm_install_dir")
         cmake_preset = f"{self.options.llvm_build_type.lower()}-win" if self.is_windows() else f"{self.options.llvm_build_type.lower()}-unix"
         cmake_extra_args = [f"--preset={cmake_preset}"]
-        if self.is_windows():
-            cmake_extra_args.append("-DLLVM_ENABLE_RUNTIMES=libcxx")
-        else:
-            cmake_extra_args.append("-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi;libunwind")
         self.cmake_workflow(llvm_subproject_dir, self.options.llvm_build_type, self.options.llvm_build_dir,
                             self.options.llvm_install_dir, cmake_extra_args)
 

third-party/llvm/CMakePresets.json

@@ -99,7 +99,8 @@
         "CMAKE_C_FLAGS_MINSIZEREL": "/MD /O1 /Ob1 /DNDEBUG",
         "CMAKE_CXX_FLAGS_MINSIZEREL": "/MD /O1 /Ob1 /DNDEBUG",
         "CMAKE_C_FLAGS_RELWITHDEBINFO": "/MD /Zi /O2 /Ob1",
-        "CMAKE_CXX_FLAGS_RELWITHDEBINFO": "/MD /Zi /O2 /Ob1"
+        "CMAKE_CXX_FLAGS_RELWITHDEBINFO": "/MD /Zi /O2 /Ob1",
+        "LLVM_ENABLE_RUNTIMES": "libcxx"
       }
     },
     {
@@ -145,7 +146,8 @@
       "displayName": "Debug-Base-Unix",
       "description": "Debug Config  without any extras and windows flags",
       "cacheVariables": {
-        "CMAKE_BUILD_TYPE": "Debug"
+        "CMAKE_BUILD_TYPE": "Debug",
+        "LLVM_ENABLE_RUNTIMES": "libcxx;libcxxabi;libunwind"
       }
     },
     {