Skip to content

Conversation

@alandefreitas
Copy link
Collaborator

@alandefreitas alandefreitas commented Dec 6, 2025

Fixes #881, moves us closer on #1113.

  • Swapped Duktape for JerryScript across CMake, CI, presets, bootstrap recipe, and the install
    docs; added a small port layer so it all hooks up cleanly.
  • Tightened the JS helper runtime: shared context lifetime, safer value accessors, clearer errors,
    and helper registration that keeps options/hash intact for block helpers; added unit tests to cover
    the new paths.
  • Added an addons-supplemental config option so you can layer extra addons/overrides; documented it and
    dropped in golden fixtures for the JS helpers. Also cleaned up the TestRunner include path.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

🚧 Danger.js checks for MrDocs are experimental; expect some rough edges while we tune the rules.

⚠️ Warnings

Warning

Commit db51f18 (feat: javascript helpers extension) changes 3164 source lines. Consider splitting it into smaller, reviewable chunks.

✨ Highlights

  • 🧪 Existing golden tests changed (behavior likely shifted)

🧾 Changes by Scope

Scope Lines Δ Lines + Lines - Files Δ Files + Files ~ Files ↔ Files -
Source 3164 1254 1910 -5 - 6 - 11
Tests 531 417 114 3 1 2 - -
Golden Tests 496 496 - 41 22 - 19 -
Third-party 271 131 140 - 3 - - 3
CI / Roadmap 195 152 43 9 1 8 - -
Docs 112 34 78 3 - 3 - -
Build / Toolchain 34 20 14 3 - 3 - -
Other 24 2 22 - - 1 - 1
Total 4827 2506 2321 54 27 23 19 15

Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)

🔝 Top Files

  • src/lib/Support/JavaScript.cpp (Source): 2641 lines Δ (+951 / -1690)
  • src/test/Support/JavaScript.cpp (Tests): 453 lines Δ (+341 / -112)
  • src/lib/Gen/hbs/Builder.cpp (Source): 283 lines Δ (+187 / -96)

Generated by 🚫 dangerJS against db51f18

@cppalliance-bot
Copy link

cppalliance-bot commented Dec 6, 2025

An automated preview of the documentation is available at https://1126.mrdocs.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-12-09 06:21:45 UTC

@alandefreitas alandefreitas force-pushed the develop branch 3 times, most recently from f689c23 to e9faceb Compare December 7, 2025 03:31
@alandefreitas alandefreitas force-pushed the develop branch 2 times, most recently from 2d51676 to 348426b Compare December 8, 2025 23:47
@alandefreitas alandefreitas force-pushed the develop branch 2 times, most recently from 2acb1e2 to f043207 Compare December 9, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explore Javascript Engines

2 participants