Skip to content

Pass unsigned chars to the functions in <cctype> #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

Pass unsigned chars to the functions in <cctype> #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc278ab
Pass unsigned chars to the functions in <cctype>
gennaroprota Jun 20, 2025
222b0f7
Merge branch 'develop' into pass_unsigned_chars_to_the_functions_in_c…
alandefreitas Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/AST/ParseJavadoc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// Copyright (c) 2023 Vinnie Falco ([email protected])
// Copyright (c) 2023 Krystian Stasiowski ([email protected])
// Copyright (c) 2024 Alan de Freitas ([email protected])
// Copyright (c) 2025 Gennaro Prota ([email protected])
//
// Official repository: https://github.com/cppalliance/mrdocs
//
Expand Down Expand Up @@ -540,7 +541,7 @@ parseStyled(StringRef s)
}
};

auto isPunctuationOrSpace = [](char c) {
auto isPunctuationOrSpace = [](unsigned char c) {
return std::isspace(c) || std::ispunct(c);
};

Expand Down
3 changes: 2 additions & 1 deletion src/lib/Support/Validate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// Copyright (c) 2023 Vinnie Falco ([email protected])
// Copyright (c) 2025 Gennaro Prota ([email protected])
//
// Official repository: https://github.com/cppalliance/mrdocs
//
Expand All @@ -29,7 +30,7 @@ validAdocSectionID(
return
s[0] == '_' ||
s[0] == ':' ||
std::isalpha(s[0]);
std::isalpha(static_cast<unsigned char>(s[0]));
}

} // mrdocs
Expand Down
Loading