Print all external commands #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An automated preview of the documentation is available at https://918.mrdocs.prtest2.cppalliance.org/index.html |
Collaborator
|
LGTM. I thought it could be an opportunity to get rid of the LLVM types we're not using in the declarations but we can do that some other time. Still... LGTM. |
This closes issue cppalliance#914.
alandefreitas
force-pushed
the
print_all_external_commands
branch
from
400ac01 to
939edc8
Compare
|
An automated preview of the documentation is available at https://918.mrdocs.prtest2.cppalliance.org/index.html |
Collaborator
Author
|
Maybe the function name should be "executeAndWaitWithLogging" (lowerCamelCase)? |
Collaborator
We can do that in passing later because otherwise we'd have to wait for CI all over again. I've been restarting CI since yerterday lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #914.