support malformed semi structured errors

Author: cppforlife

errors/error_piece.go

@@ -46,6 +46,8 @@ type ErrorPiece struct {
 
 	ReorganizePiecesAroundCommas bool
 	FormatPiecesAsList           bool
+
+	closed bool
 }
 
 func NewErrorPiecesFromString(str string) (*ErrorPiece, bool) {
@@ -70,6 +72,7 @@ func NewErrorPiecesFromString(str string) (*ErrorPiece, bool) {
 				continue
 
 			case braketClose, curlyClose, parenClose:
+				stack[len(stack)-1].closed = true
 				stack = stack[:len(stack)-1]
 				continue
 			}
@@ -84,6 +87,7 @@ func NewErrorPiecesFromString(str string) (*ErrorPiece, bool) {
 
 		case checkBackward(str, i, rawClose):
 			stack[len(stack)-1].AddStr(charStr)
+			stack[len(stack)-1].closed = true
 			stack = stack[:len(stack)-1]
 
 		default:
@@ -206,7 +210,9 @@ func (p *ErrorPiece) AsString() string {
 		for _, piece := range p.Pieces {
 			result += piece.AsString()
 		}
-		result += sepClosers[p.ContainerType]
+		if p.closed {
+			result += sepClosers[p.ContainerType]
+		}
 	}
 
 	return result

errors/multi_line_error.go

@@ -28,10 +28,7 @@ func (e MultiLineError) Error() (result string) {
 
 	lines := strings.Split(e.err.Error(), "\n")
 
-	firstLineRootPiece, complete := NewErrorPiecesFromString(lines[0])
-	if !complete {
-		return e.err.Error() // cannot deconstruct error message, return original
-	}
+	firstLineRootPiece, _ := NewErrorPiecesFromString(lines[0])
 
 	for _, piece := range firstLineRootPiece.Pieces {
 		// Do not split withing container pieces

errors/mutli_line_error_test.go

@@ -41,6 +41,16 @@ Applying create deployment/frontend (apps/v1) namespace: default:
   - spec.template.spec.restartPolicy: Unsupported value: "Always": supported values: "OnFailure", "Never"
 
  (reason: Invalid)
+`,
+		},
+		{
+			// TODO may be deal with this better
+			Description: "uneven bracing",
+			Actual:      `Applying create service/redis-master (v1) namespace: default: Creating resource service/redis-master (v1) namespace: default: Service in version "v1" cannot be handled as a Service: v1.Service.Spec: v1.ServiceSpec.Ports: []v1.ServicePort: decode slice: expect [ or n, but found ", error found in #10 byte of ...|{"ports":"foo","sele|..., bigger context ...|s-master","namespace":"default"},"spec":{"ports":"foo","selector":{"app":"redis","kapp.k14s.io/app":|... (reason: BadRequest)`,
+			Expected: `
+Applying create service/redis-master (v1) namespace: default:
+  Creating resource service/redis-master (v1) namespace: default:
+    Service in version "v1" cannot be handled as a Service: v1.Service.Spec: v1.ServiceSpec.Ports: []v1.ServicePort: decode slice: expect [ or n, but found ", error found in #10 byte of ...|{"ports":"foo","sele|..., bigger context ...|s-master","namespace":"default"},"spec":{"ports":"foo","selector":{"app":"redis","kapp.k14s.io/app":|... (reason: BadRequest)
 `,
 		},
 	}