Fixed most of clang-tidy's performance checks

Author: eidheim

src/cmake.cc

@@ -272,11 +272,11 @@ void CMake::parse_variable_parameters(std::string &data) {
 
   //Remove variables we do not know:
   pos=data.find("${");
-  auto pos_end=data.find("}", pos+2);
+  auto pos_end=data.find('}', pos+2);
   while(pos!=std::string::npos && pos_end!=std::string::npos) {
     data.erase(pos, pos_end-pos+1);
     pos=data.find("${");
-    pos_end=data.find("}", pos+2);
+    pos_end=data.find('}', pos+2);
   }
 }
 

src/ctags.cc

@@ -100,7 +100,7 @@ Ctags::Location Ctags::get_location(const std::string &line, bool markup) {
 }
 
 ///Split up a type into its various significant parts
-std::vector<std::string> Ctags::get_type_parts(const std::string type) {
+std::vector<std::string> Ctags::get_type_parts(const std::string &type) {
   std::vector<std::string> parts;
   size_t text_start=-1;
   for(size_t c=0;c<type.size();++c) {

src/ctags.h

@@ -23,5 +23,5 @@ class Ctags {
 
   static std::vector<Location> get_locations(const boost::filesystem::path &path, const std::string &name, const std::string &type);
 private:
-  static std::vector<std::string> get_type_parts(const std::string type);
+  static std::vector<std::string> get_type_parts(const std::string &type);
 };

src/debug_lldb.cc

@@ -103,6 +103,7 @@ void Debug::LLDB::start(const std::string &command, const boost::filesystem::pat
   auto &arguments=std::get<2>(parsed_run_arguments);
 
   std::vector<const char*> argv;
+  argv.reserve(arguments.size());
   for(auto &argument : arguments)
     argv.emplace_back(argument.c_str());
   argv.emplace_back(nullptr);
@@ -149,6 +150,7 @@ void Debug::LLDB::start(const std::string &command, const boost::filesystem::pat
 
     // Create environment array
     std::vector<const char*> environment;
+    environment.reserve(environment_from_arguments.size());
     for(auto &e: environment_from_arguments)
       environment.emplace_back(e.c_str());
     environment.emplace_back(nullptr);
@@ -160,6 +162,7 @@ void Debug::LLDB::start(const std::string &command, const boost::filesystem::pat
   else {
     // Create environment array
     std::vector<const char*> environment;
+    environment.reserve(environment_from_arguments.size());
     for(auto &e: environment_from_arguments)
       environment.emplace_back(e.c_str());
     size_t environ_size=0;

src/directories.cc

@@ -394,7 +394,7 @@ void Directories::update() {
     add_or_update_path(directory.first, directory.second, false);
 }
 
-void Directories::on_save_file(boost::filesystem::path file_path) {
+void Directories::on_save_file(const boost::filesystem::path &file_path) {
   auto it=directories.find(file_path.parent_path().string());
   if(it!=directories.end()) {
     if(it->second.repository)
@@ -639,8 +639,9 @@ void Directories::remove_path(const boost::filesystem::path &dir_path) {
   }
 }
 
-void Directories::colorize_path(const boost::filesystem::path &dir_path, bool include_parent_paths) {
-  auto it=directories.find(dir_path.string());
+void Directories::colorize_path(boost::filesystem::path dir_path_, bool include_parent_paths) {
+  auto dir_path=std::make_shared<boost::filesystem::path>(std::move(dir_path_));
+  auto it=directories.find(dir_path->string());
   if(it==directories.end())
     return;
 
@@ -655,8 +656,8 @@ void Directories::colorize_path(const boost::filesystem::path &dir_path, bool in
         Terminal::get().async_print(std::string("Error (git): ")+e.what()+'\n', true);
       }
 
-      dispatcher.post([this, dir_path=std::move(dir_path), include_parent_paths, status=std::move(status)] {
-        auto it=directories.find(dir_path.string());
+      dispatcher.post([this, dir_path, include_parent_paths, status=std::move(status)] {
+        auto it=directories.find(dir_path->string());
         if(it==directories.end())
           return;
 

src/directories.h

@@ -60,7 +60,7 @@ class Directories : public Gtk::ListViewText {
 
   void open(const boost::filesystem::path &dir_path="");
   void update();
-  void on_save_file(boost::filesystem::path file_path);
+  void on_save_file(const boost::filesystem::path &file_path);
   void select(const boost::filesystem::path &path);
 
   boost::filesystem::path path;
@@ -71,7 +71,7 @@ class Directories : public Gtk::ListViewText {
 private:
   void add_or_update_path(const boost::filesystem::path &dir_path, const Gtk::TreeModel::Row &row, bool include_parent_paths);
   void remove_path(const boost::filesystem::path &dir_path);
-  void colorize_path(const boost::filesystem::path &dir_path, bool include_parent_paths);
+  void colorize_path(boost::filesystem::path dir_path_, bool include_parent_paths);
 
   Glib::RefPtr<Gtk::TreeStore> tree_store;
   TreeStore::ColumnRecord column_record;

src/documentation_cppreference.cc

@@ -1,7 +1,7 @@
 #include "documentation_cppreference.h"
 #include <unordered_map>
 
-std::string Documentation::CppReference::get_url(const std::string symbol) noexcept {
+std::string Documentation::CppReference::get_url(const std::string &symbol) noexcept {
   // Copied from http://upload.cppreference.com/mwiki/images/d/df/html_book_20170409.zip/reference/cppreference-export-ns0,4,8,10.xml
   // Using raw string instead of map to reduce compile time
   const static std::string symbol_urls = R"(size_t	c/types/size_t

src/documentation_cppreference.h

@@ -4,6 +4,6 @@
 namespace Documentation {
   class CppReference {
   public:
-    static std::string get_url(const std::string symbol) noexcept;
+    static std::string get_url(const std::string &symbol) noexcept;
   };
 }

src/menu.cc

@@ -477,7 +477,7 @@ const Glib::ustring menu_xml= R"RAW(<interface>
 </interface>
 )RAW";
 
-void Menu::add_action(const std::string &name, std::function<void()> action) {
+void Menu::add_action(const std::string &name, const std::function<void()> &action) {
   auto g_application=g_application_get_default();
   auto gio_application=Glib::wrap(g_application, true);
   auto application=Glib::RefPtr<Gtk::Application>::cast_static(gio_application);

src/menu.h

@@ -12,7 +12,7 @@ class Menu {
     return singleton;
   }
 
-  void add_action(const std::string &name, std::function<void()> action);
+  void add_action(const std::string &name, const std::function<void()> &action);
   std::unordered_map<std::string, Glib::RefPtr<Gio::SimpleAction> > actions;
   void set_keys();