Remove serial visitor.

Author: cpwright

engine/table/src/main/java/io/deephaven/engine/table/impl/DeferredViewTable.java

@@ -11,7 +11,6 @@
 import io.deephaven.engine.table.impl.filter.ExtractBarriers;
 import io.deephaven.engine.table.impl.filter.ExtractInnerConjunctiveFilters;
 import io.deephaven.engine.table.impl.filter.ExtractRespectedBarriers;
-import io.deephaven.engine.table.impl.filter.ExtractSerialFilters;
 import io.deephaven.engine.table.impl.select.analyzers.SelectAndViewAnalyzer;
 import io.deephaven.engine.table.impl.select.MatchFilter;
 import io.deephaven.engine.liveness.LivenessArtifact;
@@ -194,7 +193,7 @@ private PreAndPostFilters applyFilterRenamings(WhereFilter[] filters) {
                     ExtractRespectedBarriers.stream(filter).anyMatch(postViewBarriers::contains);
             if (isPostView || serialFilterFound || hasPostViewBarrier) {
                 // if this filter is serial, all subsequent filters must be postViewFilters
-                if (ExtractSerialFilters.hasAny(filter)) {
+                if (filter.isSerial()) {
                     serialFilterFound = true;
                 }
                 postViewFilters.add(filter);
@@ -289,7 +288,7 @@ public WhereFilter visit(ConjunctiveFilter filter) {
                 preViewFilters.add(preFilter);
             } else {
                 // if this filter is serial, all subsequent filters must be postViewFilters
-                if (ExtractSerialFilters.hasAny(filter)) {
+                if (filter.isSerial()) {
                     serialFilterFound = true;
                 }
 

engine/table/src/main/java/io/deephaven/engine/table/impl/PartitionAwareSourceTable.java

@@ -11,7 +11,6 @@
 import io.deephaven.engine.table.impl.filter.ExtractBarriers;
 import io.deephaven.engine.table.impl.filter.ExtractInnerConjunctiveFilters;
 import io.deephaven.engine.table.impl.filter.ExtractRespectedBarriers;
-import io.deephaven.engine.table.impl.filter.ExtractSerialFilters;
 import io.deephaven.engine.table.impl.select.analyzers.SelectAndViewAnalyzer;
 import io.deephaven.engine.updategraph.UpdateSourceRegistrar;
 import io.deephaven.engine.table.impl.perf.QueryPerformanceRecorder;
@@ -127,7 +126,7 @@ protected TableAndRemainingFilters getWithWhere(WhereFilter... whereFilters) {
             boolean serialFilterFound = false;
             final Set<Object> partitionBarriers = new HashSet<>();
             for (WhereFilter whereFilter : whereFilters) {
-                if (ExtractSerialFilters.hasAny(whereFilter)) {
+                if (whereFilter.isSerial()) {
                     serialFilterFound = true;
                 }
 
@@ -314,7 +313,7 @@ private Table whereImpl(final List<WhereFilter> whereFilters) {
             whereFilter.init(definition, compilationProcessor);
 
             // Test for user-mandated serial filters (e.g. FilterSerial.of() or Filter.serial())
-            if (ExtractSerialFilters.hasAny(whereFilter)) {
+            if (whereFilter.isSerial()) {
                 serialFilterFound = true;
             }
 

engine/table/src/main/java/io/deephaven/engine/table/impl/filter/ExtractSerialFilters.java

@@ -156,4 +156,9 @@ public int hashCode() {
     public boolean permitParallelization() {
         return Arrays.stream(componentFilters).allMatch(WhereFilter::permitParallelization);
     }
+
+    @Override
+    public boolean isSerial() {
+        return Arrays.stream(componentFilters).anyMatch(WhereFilter::isSerial);
+    }
 }

engine/table/src/main/java/io/deephaven/engine/table/impl/select/ComposedFilter.java

@@ -279,6 +279,13 @@ default boolean permitParallelization() {
         return true;
     }
 
+    /**
+     * Return true if this filter is a serial filter.
+     */
+    default boolean isSerial() {
+        return false;
+    }
+
     /**
      * Set the {@link RecomputeListener} that should be notified if results based on this WhereFilter must be
      * recomputed.

engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilter.java

@@ -128,6 +128,11 @@ public boolean permitParallelization() {
         return filter.permitParallelization();
     }
 
+    @Override
+    public boolean isSerial() {
+        return filter.isSerial();
+    }
+
     @Override
     public boolean equals(Object o) {
         if (this == o)

engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterDelegatingBase.java

@@ -31,6 +31,11 @@ public boolean permitParallelization() {
         return false;
     }
 
+    @Override
+    public boolean isSerial() {
+        return true;
+    }
+
     public WhereFilter copy() {
         return new WhereFilterSerialImpl(filter.copy());
     }

engine/table/src/main/java/io/deephaven/engine/table/impl/select/WhereFilterSerialImpl.java

@@ -133,6 +133,16 @@ public boolean isSimpleFilter() {
     @Override
     public void setRecomputeListener(final RecomputeListener result) {}
 
+    @Override
+    public boolean permitParallelization() {
+        return componentFilter.permitParallelization();
+    }
+
+    @Override
+    public boolean isSerial() {
+        return componentFilter.isSerial();
+    }
+
     @Override
     public WhereFilter copy() {
         return new VectorComponentFilterWrapper(columnName, isArray, componentType, componentFilter.copy());
@@ -257,5 +267,15 @@ public void setRecomputeListener(final RecomputeListener result) {
         public WhereFilter copy() {
             return new TypeDiscardedFilter(wrapped.copy());
         }
+
+        @Override
+        public boolean isSerial() {
+            return wrapped.isSerial();
+        }
+
+        @Override
+        public boolean permitParallelization() {
+            return wrapped.permitParallelization();
+        }
     }
 }

engine/table/src/main/java/io/deephaven/engine/table/impl/select/vectorchunkfilter/VectorComponentFilterWrapper.java

@@ -107,6 +107,11 @@ public boolean permitParallelization() {
         return innerFilter == null || innerFilter.permitParallelization();
     }
 
+    @Override
+    public boolean isSerial() {
+        return innerFilter != null && innerFilter.isSerial();
+    }
+
     @Override
     public void setRecomputeListener(WhereFilter.RecomputeListener result) {
         if (innerFilter != null) {