Sync Dashing & Eloquent (#568)

* Fixing minor uncrustify failures. (#532)

* Adding missing test dependency. (#534)

* remove unneeded dependencies on rcl and angles (#537)

* Ensure robot_localization filters use ROS 2 time properly. (#536)

* Ensure robot_localization filters use ROS 2 time properly.

Signed-off-by: Michel Hidalgo <[email protected]>

* Use generic timer instead of wall timer.

Signed-off-by: Michel Hidalgo <[email protected]>

* add launch_ros exec_depend (#539)

* print compiler optimization msg to stdout instead of stderr (#542)

* Fix FilterBaseDiagnosticsTest.EmptyTimestamps test on amd64 (#541)

* publish empty timestamp message for longer

* change qos to keep_all for FilterBaseDiagnosticsTest.EmptyTimestamps test

* remove debug printouts

* fix cpplint

* Attempt to fix binary build test errors (#548)

* dependencies

Signed-off-by: Mabel Zhang <[email protected]>

* link tests with rosidl_typesupport_cpp

Signed-off-by: Mabel Zhang <[email protected]>

* fix uncrustify

Signed-off-by: Mabel Zhang <[email protected]>

* revert uncrustify

* Modified to get datum array param (#549)

* Modified get datum params

* Leave vector to default constructor #549

* Fixing dual_ekf_navsat_example.yaml parameter file for dashing branch (#556)

* Fixing dual_ekf_navsat_example paramter file for ros-dashing

* Fixing 'value type integer' error

* Fix utm coordinate print (#563)

* Fix get parameters (#552)

* Modified get datum params

* Leave vector to default constructor #549

* Deleted vector init statements

* Deleted initialization of `initial_state` vector

* Added default values of acceleration_limits

* Added vector resized when use_control param set false

* uncrustify fix

Co-authored-by: Joshua Whitley <[email protected]>
Co-authored-by: Mabel Zhang <[email protected]>
Co-authored-by: Michel Hidalgo <[email protected]>
Co-authored-by: Taehun Lim <[email protected]>
Co-authored-by: Pankhuri Vanjani <[email protected]>
Co-authored-by: floroeske <[email protected]>

Author: 7 people

CMakeLists.txt

@@ -10,12 +10,11 @@ if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
 endif()
 
 if(NOT CMAKE_CONFIGURATION_TYPES AND NOT CMAKE_BUILD_TYPE)
-  message("${PROJECT_NAME}: You did not request a specific build type: selecting 'RelWithDebInfo'.")
+  message(STATUS "${PROJECT_NAME}: You did not request a specific build type: selecting 'RelWithDebInfo'.")
   set(CMAKE_BUILD_TYPE RelWithDebInfo)
 endif()
 
 find_package(ament_cmake REQUIRED)
-find_package(rcl REQUIRED)
 find_package(rclcpp REQUIRED)
 find_package(diagnostic_msgs REQUIRED)
 find_package(diagnostic_updater REQUIRED)
@@ -105,7 +104,6 @@ ament_target_dependencies(
   geographic_msgs
   geometry_msgs
   nav_msgs
-  rcl
   rclcpp
   sensor_msgs
   std_msgs
@@ -162,7 +160,7 @@ if(BUILD_TESTING)
   find_package(ament_cmake_cpplint REQUIRED)
   find_package(ament_cmake_lint_cmake REQUIRED)
   find_package(ament_cmake_uncrustify REQUIRED)
-  find_package(launch_testing_ament_cmake)
+  find_package(launch_testing_ament_cmake REQUIRED)
 
   #### FILTER BASE TESTS ####
   ament_add_gtest(filter_base-test test/test_filter_base.cpp)
@@ -172,6 +170,8 @@ if(BUILD_TESTING)
   ament_add_gtest_executable(test_filter_base_diagnostics_timestamps
                     test/test_filter_base_diagnostics_timestamps.cpp)
   target_link_libraries(test_filter_base_diagnostics_timestamps ${library_name})
+  rosidl_target_interfaces(test_filter_base_diagnostics_timestamps
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
   add_dependencies(test_filter_base_diagnostics_timestamps ekf_node)
   ament_add_test(test_filter_base_diagnostics_timestamps
     GENERATE_RESULT_FOR_RETURN_CODE_ZERO
@@ -183,10 +183,14 @@ if(BUILD_TESTING)
   #### EKF TESTS ######
   ament_add_gtest(test_ekf test/test_ekf.cpp)
   target_link_libraries(test_ekf ${library_name})
+  rosidl_target_interfaces(test_ekf
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
 
   ament_add_gtest_executable(test_ekf_localization_node_interfaces
                     test/test_ekf_localization_node_interfaces.cpp)
   target_link_libraries(test_ekf_localization_node_interfaces ${library_name})
+  rosidl_target_interfaces(test_ekf_localization_node_interfaces
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
   add_dependencies(test_ekf_localization_node_interfaces ekf_node)
   ament_add_test(test_ekf_localization_node_interfaces
     GENERATE_RESULT_FOR_RETURN_CODE_ZERO
@@ -198,11 +202,15 @@ if(BUILD_TESTING)
   #### UKF TESTS #####
   ament_add_gtest(test_ukf test/test_ukf.cpp)
   target_link_libraries(test_ukf ${library_name})
+  rosidl_target_interfaces(test_ukf
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
 
 
   ament_add_gtest_executable(test_ukf_localization_node_interfaces
                     test/test_ukf_localization_node_interfaces.cpp)
   target_link_libraries(test_ukf_localization_node_interfaces ${library_name})
+  rosidl_target_interfaces(test_ukf_localization_node_interfaces
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
   add_dependencies(test_ukf_localization_node_interfaces ekf_node)
   ament_add_test(test_ukf_localization_node_interfaces
     GENERATE_RESULT_FOR_RETURN_CODE_ZERO
@@ -234,6 +242,8 @@ if(BUILD_TESTING)
   ament_add_gtest_executable(test_robot_localization_estimator
                   test/test_robot_localization_estimator.cpp)
   target_link_libraries(test_robot_localization_estimator ${library_name})
+  rosidl_target_interfaces(test_robot_localization_estimator
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
   ament_add_test(test_robot_localization_estimator
     GENERATE_RESULT_FOR_RETURN_CODE_ZERO
     TIMEOUT 100
@@ -244,9 +254,13 @@ if(BUILD_TESTING)
   ament_add_gtest_executable(test_ros_robot_localization_listener
                   test/test_ros_robot_localization_listener.cpp)
   target_link_libraries(test_ros_robot_localization_listener ${library_name})
+  rosidl_target_interfaces(test_ros_robot_localization_listener
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
   ament_add_gtest_executable(test_ros_robot_localization_listener_publisher
                   test/test_ros_robot_localization_listener_publisher.cpp)
   target_link_libraries(test_ros_robot_localization_listener_publisher ${library_name})
+  rosidl_target_interfaces(test_ros_robot_localization_listener_publisher
+    ${PROJECT_NAME} "rosidl_typesupport_cpp")
   ament_add_test(test_ros_robot_localization_listener
     GENERATE_RESULT_FOR_RETURN_CODE_ZERO
     TIMEOUT 100
@@ -307,4 +321,5 @@ install(DIRECTORY
 
 ament_export_include_directories(include)
 ament_export_libraries(${library_name})
+ament_export_dependencies(rosidl_default_runtime)
 ament_package()

package.xml

@@ -17,14 +17,12 @@
   <buildtool_depend>builtin_interfaces</buildtool_depend>
   <buildtool_depend>rosidl_default_generators</buildtool_depend>
 
-  <depend>angles</depend>
   <depend>eigen</depend>
   <depend>geographic_msgs</depend>
   <depend>geometry_msgs</depend>
   <depend>diagnostic_msgs</depend>
   <depend>diagnostic_updater</depend>
   <depend>nav_msgs</depend>
-  <build_depend>rcl</build_depend>
   <build_depend>rclcpp</build_depend>
   <build_depend>rmw_implementation</build_depend>
   <depend>sensor_msgs</depend>
@@ -45,6 +43,8 @@
 
   <test_depend>ament_lint_auto</test_depend>
   <test_depend>ament_lint_common</test_depend>
+  <test_depend>launch_ros</test_depend>
+  <test_depend>launch_testing_ament_cmake</test_depend>
 
   <member_of_group>rosidl_interface_packages</member_of_group>