Skip to content

Commit 0d3f083

Browse files
fix(ci): use cargo build for dioxus example (#411)
* fix(ci): use cargo build for dioxus example The dioxus example is a plain desktop app with no dx-specific features. Replace `dx build` with `cargo build --release` so the binary lands in `target/release/` where cargo-packager expects it. This fixes the package CI job on all three platforms: - macOS/Windows: binary now at the expected path - Ubuntu: no longer requires GLIBC 2.38+ from the dx binary Remove the `cargo binstall dioxus-cli` CI step (no longer needed). * add todo --------- Co-authored-by: Fabian-Lars <118197967+FabianLars-crabnebula@users.noreply.github.com>
1 parent 949ec2c commit 0d3f083

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/build-examples.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,5 @@ jobs:
3939
- run: go install github.com/wailsapp/wails/v2/cmd/wails@latest
4040
- run: cargo install cargo-binstall --locked
4141
- run: cargo binstall tauri-cli --locked --force
42-
- run: cargo binstall dioxus-cli --locked --force
4342
- run: cargo r --package cargo-packager -- signer generate --password '123' --path ./signing-key -vvv
4443
- run: cargo r --package cargo-packager -- --release --private-key ./signing-key --password '123' --formats all -vvv

examples/dioxus/Cargo.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@ publish = false
88
dioxus = { version = "0.7", features = ["desktop"] }
99

1010
[package.metadata.packager]
11-
before-packaging-command = "dx build --platform desktop --release"
11+
# TODO: Needs https://github.com/crabnebula-dev/cargo-packager/issues/360
12+
# before-packaging-command = "dx build --platform desktop --release"
13+
before-packaging-command = "cargo build --release"
1214
out-dir = "./dist"
1315
product-name = "Dioxus example"
1416
identifier = "com.dioxus.example"

0 commit comments

Comments
 (0)