feat(appimage)!: more useful error message

feat(appimage)!: more useful error message

Author: Marc Jakobi

.changes/feat-appimage-improved-error-message.md

@@ -0,0 +1,7 @@
+---
+"cargo-packager": minor
+"@crabnebula/packager": minor
+---
+
+Changed the error message when running the AppImage build script fails.
+It now includes the full path to the build script.

crates/packager/src/error.rs

@@ -95,9 +95,9 @@ pub enum Error {
     /// Custom signing command error
     #[error("Error running custom signing command: {0}")]
     CustomSignCommandFailed(std::io::Error),
-    /// bundle_appimage script error
-    #[error("Error running bundle_appimage.sh script: {0}")]
-    AppImageScriptFailed(std::io::Error),
+    /// build_appimage script error
+    #[error("Error running {0} script: {1}")]
+    AppImageScriptFailed(PathBuf, std::io::Error),
     /// Failed to get parent directory of a path
     #[error("Failed to get parent directory of {0}")]
     ParentDirNotFound(PathBuf),

crates/packager/src/package/appimage/mod.rs

@@ -208,7 +208,7 @@ pub(crate) fn package(ctx: &Context) -> crate::Result<Vec<PathBuf>> {
     Command::new(&sh_file)
         .current_dir(intermediates_path)
         .output_ok()
-        .map_err(crate::Error::AppImageScriptFailed)?;
+        .map_err(|e| crate::Error::AppImageScriptFailed(sh_file, e))?;
 
     Ok(vec![appimage_path])
 }